[GitHub] KellenSunderland commented on a change in pull request #9918: [MXNET-74]Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-12 Thread GitBox 
KellenSunderland commented on a change in pull request #9918: [MXNET-74]Update 
mkldnn to the newest & Add clang build test with mkldnn.
URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r173845939
 
 

 ##
 File path: Jenkinsfile
 ##
 @@ -175,6 +175,24 @@ try {
 }
   }
 },
+'CPU: Clang 3.9 MKLDNN': {
+  node('mxnetlinux-cpu') {
+ws('workspace/build-cpu-clang39') {
 
 Review comment:
   I think we're trying to give each build task its own unique workspace.  I'd 
recommend we change this to:
   
   ```
   ws('workspace/build-cpu-mkldnn-clang39')
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] KellenSunderland commented on a change in pull request #9918: [MXNET-74]Update mkldnn to the newest & Add clang build test with mkldnn.

2018-03-12 Thread GitBox 
KellenSunderland commented on a change in pull request #9918: [MXNET-74]Update 
mkldnn to the newest & Add clang build test with mkldnn.
URL: https://github.com/apache/incubator-mxnet/pull/9918#discussion_r173846106
 
 

 ##
 File path: Jenkinsfile
 ##
 @@ -175,6 +175,24 @@ try {
 }
   }
 },
+'CPU: Clang 3.9 MKLDNN': {
+  node('mxnetlinux-cpu') {
+ws('workspace/build-cpu-clang39') {
+  init_git()
+  sh "ci/build.py --build --platform ubuntu_cpu 
/work/runtime_functions.sh build_ubuntu_cpu_clang39_mkldnn"
+  pack_lib('mkldnn_cpu', mx_mkldnn_lib)
+}
+  }
+},
+'CPU: Clang 5 MKLDNN': {
+  node('mxnetlinux-cpu') {
+ws('workspace/build-cpu-clang50') {
 
 Review comment:
   and 
   ```
   ws('workspace/build-cpu-mkldnn-clang50')
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services