ThomasDelteil commented on a change in pull request #10490: Python: Resolve
some of the undefined names
URL: https://github.com/apache/incubator-mxnet/pull/10490#discussion_r181154108
##########
File path: python/mxnet/gluon/parameter.py
##########
@@ -646,7 +647,7 @@ def get_constant(self, name, value=None):
assert isinstance(param, Constant), \
"Parameter '{}' already exists but it is not a
constant.".format(
name)
- if isinstance(value, nd.NDArray):
+ if isinstance(value, mx.nd.NDArray):
Review comment:
`nd` has been imported as `ndarray` so you could use `ndarray.NDArray` I
think to remain consistent with how it's been done in this file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
