[GitHub] aaronmarkham commented on issue #11670: Docs build improvements
aaronmarkham commented on issue #11670: Docs build improvements URL: https://github.com/apache/incubator-mxnet/pull/11670#issuecomment-405605137  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11670: Docs build improvements
aaronmarkham commented on issue #11670: Docs build improvements URL: https://github.com/apache/incubator-mxnet/pull/11670#issuecomment-405345816 @szha @marcoabreu @nswamy - can any of you merge? Any reason to keep this in limbo? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11670: Docs build improvements
aaronmarkham commented on issue #11670: Docs build improvements URL: https://github.com/apache/incubator-mxnet/pull/11670#issuecomment-404970330 I just found out I put the wrong script name in the description above. I had moved the logic to `./setup_docs_ubuntu.sh`, so just run that when you try this. Krishnan found the R gbg step to fail on his instance, so I'm pointing that to the CI's copy of the file like I did with sbt. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11670: Docs build improvements
aaronmarkham commented on issue #11670: Docs build improvements URL: https://github.com/apache/incubator-mxnet/pull/11670#issuecomment-404641268 @larroy - It does seem to skip building the full project if no change is detected, but ya, as soon as some op changes it triggers a full rebuild. I have some experience making doxygen and API docs build not so monolithic with cmake. Did we ever decide to switch to that? As for Docker, we're pretty close to that now, but since I like to build and serve for preview links on a server that doesn't go offline all the time (like my mac), I don't find a Docker option all that useful for me. What's your use case? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11670: Docs build improvements
aaronmarkham commented on issue #11670: Docs build improvements URL: https://github.com/apache/incubator-mxnet/pull/11670#issuecomment-404598252 I updated the README and it uses this script: https://github.com/apache/incubator-mxnet/pull/11670/files#diff-3bb49ab660a5d5d6192626615a92a775R128 I'd love to separate the docs/website build to a different pipeline. I think there's a lot of money spent doing CI on text updates that don't need all of that testing. Regarding OPENMP, somewhere along the line I saw something that made me believe the build runs faster with it turned on. *shrug* Would love to know one way or the other and get rid of it if we can, or maybe have the `make docs` trigger use the right flags by default. For one-click: it sort of is. You need the repo, then you run the script. That's the setup. Then, if you're developing with the website or the docs, you need to run `make docs` all of the time... That's why I suggest the `deploy.sh` script that rolls up the `make docs` step with moving the files to the web server directory. That's what I use. I can add that script too - I just thought it might be too trivial. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] aaronmarkham commented on issue #11670: Docs build improvements
aaronmarkham commented on issue #11670: Docs build improvements URL: https://github.com/apache/incubator-mxnet/pull/11670#issuecomment-404591306 @kpmurali @larroy @thomelane @ThomasDelteil @marcoabreu @nswamy - you guys will probably appreciate this. LMK if I can make any improvements, or if you find any bugs. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
