[GitHub] anirudh2290 commented on a change in pull request #11127: add import_ for SymbolBlock

2018-06-13 Thread GitBox 
anirudh2290 commented on a change in pull request #11127: add import_ for 
SymbolBlock
URL: https://github.com/apache/incubator-mxnet/pull/11127#discussion_r195302933
 
 

 ##
 File path: docs/tutorials/gluon/save_load_params.md
 ##
 @@ -61,7 +61,7 @@ def build_lenet(net):
 net.add(gluon.nn.Dense(512, activation="relu"))
 
 Review comment:
   sorry didnt realize this was already in.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anirudh2290 commented on a change in pull request #11127: add import_ for SymbolBlock

2018-06-13 Thread GitBox 
anirudh2290 commented on a change in pull request #11127: add import_ for 
SymbolBlock
URL: https://github.com/apache/incubator-mxnet/pull/11127#discussion_r195302812
 
 

 ##
 File path: docs/tutorials/gluon/save_load_params.md
 ##
 @@ -61,7 +61,7 @@ def build_lenet(net):
 net.add(gluon.nn.Dense(512, activation="relu"))
 
 Review comment:
   we can make this change as part of another PR to avoid another round of CI.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] anirudh2290 commented on a change in pull request #11127: add import_ for SymbolBlock

2018-06-07 Thread GitBox 
anirudh2290 commented on a change in pull request #11127: add import_ for 
SymbolBlock
URL: https://github.com/apache/incubator-mxnet/pull/11127#discussion_r193852944
 
 

 ##
 File path: python/mxnet/gluon/block.py
 ##
 @@ -357,6 +369,27 @@ def load_params(self, filename, ctx=None, 
allow_missing=False,
 name, filename, 
_brief_print_list(self._params.keys(
 params[name]._load_init(loaded[name], ctx)
 
+def load_params(self, filename, ctx=None, allow_missing=False,
+ignore_extra=False):
+"""[Deprecated] Please use load_parameters.
+
+Load parameters from file.
+
+filename : str
+Path to parameter file.
+ctx : Context or list of Context, default cpu()
+Context(s) initialize loaded parameters on.
+allow_missing : bool, default False
+Whether to silently skip loading parameters not represents in the 
file.
+ignore_extra : bool, default False
+Whether to silently ignore parameters from the file that are not
+present in this Block.
+"""
+warnings.warn("load_params is deprecated. Please use load_parameters.")
+import pdb;pdb.set_trace()
 
 Review comment:
   remove these pdb statements here and elsewhere ?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services