[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention
benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-362581380 @yzhliu Can you check and merge if ok? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention
benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-362180888 rebased again This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention
benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-360445475 checks have passed! @yzhliu can you have a look please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention
benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-360368130 Done. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention
benqua commented on issue #8245: Use argmax instead of argmax_channel in
Accuracy to keep dimention
URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-360282441
I did rebase.
I wonder if just changing to
```scala
val predLabel = if (pred.shape == label.shape)
NDArray.argmax(Map("axis" -> 1, "keepdims" -> true))(pred)
else NDArray.argmax_channel(pred)
```
would work but I cannot compile and test right now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention
benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-360257217 Hi, Sorry for the long delay. The problem is that while this change fix my problem on segmentation tasks, tests fails on classification tasks. I will try to find some time to further investigate, but I am not sure when I will be able to do that. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention
benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-345952216 ok, thanks. will check later how to fix this for the classification test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention
benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-341370830 I tried again, still no luck. The message from the CI doesn't help to understand if it is still a CI issue or a PR one. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention
benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-339870110 Rebased. Waiting for the CI to complete. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention
benqua commented on issue #8245: Use argmax instead of argmax_channel in Accuracy to keep dimention URL: https://github.com/apache/incubator-mxnet/pull/8245#issuecomment-336993852 I don't see why the test fails but don't think this is due to my proposed change. @Ldpe2G any idea? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
