[GitHub] cjolivier01 commented on issue #9875: Fixed indentation and added test outputs to gitignore

2018-02-23 Thread GitBox
cjolivier01 commented on issue #9875: Fixed indentation and added test outputs 
to gitignore
URL: https://github.com/apache/incubator-mxnet/pull/9875#issuecomment-368157229
 
 
   I would prefer we didn't encourage building from source tree for just that 
reason, but okay.  After all, it is legal.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cjolivier01 commented on issue #9875: Fixed indentation and added test outputs to gitignore

2018-02-23 Thread GitBox
cjolivier01 commented on issue #9875: Fixed indentation and added test outputs 
to gitignore
URL: https://github.com/apache/incubator-mxnet/pull/9875#issuecomment-368157229
 
 
   I would prefer we didn't encourage building from source tree for just that 
reason, but okay.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cjolivier01 commented on issue #9875: Fixed indentation and added test outputs to gitignore

2018-02-23 Thread GitBox
cjolivier01 commented on issue #9875: Fixed indentation and added test outputs 
to gitignore
URL: https://github.com/apache/incubator-mxnet/pull/9875#issuecomment-368157229
 
 
   I would prefer we didn't encourage building from source for just that 
reason, but okay.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cjolivier01 commented on issue #9875: Fixed indentation and added test outputs to gitignore

2018-02-23 Thread GitBox
cjolivier01 commented on issue #9875: Fixed indentation and added test outputs 
to gitignore
URL: https://github.com/apache/incubator-mxnet/pull/9875#issuecomment-368152900
 
 
   are you build cmake Makefiles in the source directory?  Generally you do it 
in a subdirectory.
   i.e.:
   ```bash
   mkdir cmake-build
   cd cmake-build
   cmake ..
   make 
   ```
   Otherwise you get all sorts of junk in the source tree like this.
   
   Won't doing it in the source tree also overwite the "real" Makefile as well?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] cjolivier01 commented on issue #9875: Fixed indentation and added test outputs to gitignore

2018-02-23 Thread GitBox
cjolivier01 commented on issue #9875: Fixed indentation and added test outputs 
to gitignore
URL: https://github.com/apache/incubator-mxnet/pull/9875#issuecomment-368152900
 
 
   are you build cmake Makefiles in the source directory?  Generally you do it 
in a subdirectory.
   i.e.:
   ```bash
   mkdir cmake-build
   cd cmake-build
   cmake ..
   make 
   ```
   Otherwise you get all sorts of junk in the source tree like this.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services