[GitHub] craftit commented on issue #7399: Remove inline keyword from methods we want to generate code for.
craftit commented on issue #7399: Remove inline keyword from methods we want to generate code for. URL: https://github.com/apache/incubator-mxnet/pull/7399#issuecomment-321328363 @lx75249 Ahh I see what you mean, existing code will just include MxNetCpp.h everywhere. In that case this patch is a bad idea. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] craftit commented on issue #7399: Remove inline keyword from methods we want to generate code for.
craftit commented on issue #7399: Remove inline keyword from methods we want to generate code for. URL: https://github.com/apache/incubator-mxnet/pull/7399#issuecomment-321324943 Essentially the hpp files could be renamed .cpp files. To use this library I just include all the .hpp header files into a single source file in my project. In many ways that works quite well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] craftit commented on issue #7399: Remove inline keyword from methods we want to generate code for.
craftit commented on issue #7399: Remove inline keyword from methods we want to generate code for. URL: https://github.com/apache/incubator-mxnet/pull/7399#issuecomment-321324357 The definitions are in the .hpp, the normal head files have extension .hh the files are kept separate to avoid creating a library for the c++ client code. The current code works because all the examples are compiled with a single file per executable. I have tested this change and need it to link cpp-package into a larger project. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
