[GitHub] eric-haibin-lin commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check
eric-haibin-lin commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check URL: https://github.com/apache/incubator-mxnet/pull/10390#discussion_r179229683 ## File path: tests/nightly/apache_rat_license_check/.rat-excludes ## @@ -0,0 +1,54 @@ +.*xml +\..* +.*css +\\.* +.*ipynb +.*html +.*json +.*js +.*txt +.*md +3rdparty/* +R-package/* +src/operator/mkl/* +trunk/* +docker/* +docker_multiarch/* +.*\\.m +.*\\.mk +.*\\.R +contrib/* +Dockerfile* +.*svg +.*cfg +.*config +docs/* +__init__.py +build/* +.*\\.t +perl-package/* +.*csv +.*names +CODEOWNERS +prepare_mkl.sh +readthedocs.yml +snap.python +snapcraft.yaml +image-classification-predict.cc +bbox.pyx +cpu_nms.pyx +gpu_nms.pyx +nms_kernel.cu +_mask.pyx +unicodemap_en_baidu.csv +coco.py +base.pyi +special_functions-inl.h +im2col.cuh +im2col.h +pool.h +README.rst +dataset.cPickle + +rcnn/* Review comment: Why excluding these two examples? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eric-haibin-lin commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check
eric-haibin-lin commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check URL: https://github.com/apache/incubator-mxnet/pull/10390#discussion_r179229299 ## File path: tests/nightly/apache_rat_license_check/.rat-excludes ## @@ -0,0 +1,54 @@ +.*xml +\..* +.*css +\\.* +.*ipynb +.*html +.*json +.*js +.*txt +.*md +3rdparty/* +R-package/* +src/operator/mkl/* +trunk/* +docker/* +docker_multiarch/* +.*\\.m +.*\\.mk +.*\\.R +contrib/* Review comment: the contrib folder is ignored? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eric-haibin-lin commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check
eric-haibin-lin commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check URL: https://github.com/apache/incubator-mxnet/pull/10390#discussion_r179229493 ## File path: tests/nightly/apache_rat_license_check/.rat-excludes ## @@ -0,0 +1,54 @@ +.*xml +\..* +.*css +\\.* +.*ipynb +.*html +.*json +.*js +.*txt +.*md +3rdparty/* +R-package/* +src/operator/mkl/* +trunk/* +docker/* +docker_multiarch/* +.*\\.m +.*\\.mk +.*\\.R +contrib/* +Dockerfile* +.*svg +.*cfg +.*config +docs/* +__init__.py +build/* +.*\\.t +perl-package/* Review comment: Ignoring the entire perl-package? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
