[GitHub] eric-haibin-lin commented on a change in pull request #10392: [MXNET-266] Fix cudnn_conv and cudnn_deconv deadlock

2018-04-04 Thread GitBox 
eric-haibin-lin commented on a change in pull request #10392: [MXNET-266] Fix 
cudnn_conv and cudnn_deconv deadlock
URL: https://github.com/apache/incubator-mxnet/pull/10392#discussion_r179226575
 
 

 ##
 File path: src/operator/nn/cudnn/cudnn_convolution-inl.h
 ##
 @@ -512,18 +511,15 @@ class CuDNNConvolutionOp {
 }
   }
 
-  void SelectAlgo(const Context& ctx,
+  void SelectAlgo(const RunContext& rctx,
   const std::vector& in_shape,
   const std::vector& out_shape,
   cudnnDataType_t cudnn_forward_compute_type,
   cudnnDataType_t cudnn_backward_compute_type) {
 if (!CuDNNConvAlgoReg::Get()->Find(param_, in_shape, out_shape, dtype_,
cudnn_forward_compute_type, 
cudnn_backward_compute_type,
-   SMArch(ctx.dev_id), _algo_, 
_algo_,
+   SMArch(rctx.ctx.dev_id), 
_algo_, _algo_,
_algo_w_)) {
-  // Not in algo registry, must determine via *Get*() or *Find*()
-  Engine::VarHandle var = Engine::Get()->NewVariable();
-  Engine::Get()->PushAsync([=](RunContext rctx, Engine::CallbackOnComplete 
on_complete) {
 mshadow::Stream *s = rctx.get_stream();
 
 Review comment:
   nit: indentation?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] eric-haibin-lin commented on a change in pull request #10392: [MXNET-266] Fix cudnn_conv and cudnn_deconv deadlock

2018-04-04 Thread GitBox 
eric-haibin-lin commented on a change in pull request #10392: [MXNET-266] Fix 
cudnn_conv and cudnn_deconv deadlock
URL: https://github.com/apache/incubator-mxnet/pull/10392#discussion_r179226688
 
 

 ##
 File path: src/operator/nn/cudnn/cudnn_deconvolution-inl.h
 ##
 @@ -536,19 +535,16 @@ class CuDNNDeconvolutionOp {
 }
   }
 
-  void SelectAlgo(const Context& ctx,
+  void SelectAlgo(const RunContext& rctx,
   const std::vector& in_shape,
   const std::vector& out_shape,
   cudnnDataType_t cudnn_forward_compute_type,
   cudnnDataType_t cudnn_backward_compute_type) {
 if (!CuDNNDeconvAlgoReg::Get()->Find(param_, in_shape, out_shape, dtype_,
  cudnn_forward_compute_type,
  cudnn_backward_compute_type,
- SMArch(ctx.dev_id), _algo_,
+ SMArch(rctx.ctx.dev_id), 
_algo_,
  _algo_, _algo_w_)) {
-  // Not in algo registry, must determine via *Get*() or *Find*()
-  Engine::VarHandle var = Engine::Get()->NewVariable();
-  Engine::Get()->PushAsync([=](RunContext rctx, Engine::CallbackOnComplete 
on_complete) {
 
 Review comment:
   nit: indentation?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services