[GitHub] haojin2 commented on a change in pull request #10078: Support float16 in L2Normalization operator
haojin2 commented on a change in pull request #10078: Support float16 in
L2Normalization operator
URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r174202873
##
File path: src/operator/l2_normalization.cc
##
@@ -26,13 +26,22 @@
namespace mxnet {
namespace op {
template<>
-Operator* CreateOp(L2NormalizationParam param) {
- return new L2NormalizationOp(param);
+Operator* CreateOp(L2NormalizationParam param, int dtype) {
+ Operator* op = NULL;
+ MSHADOW_REAL_TYPE_SWITCH(dtype, DType, {
+op = new L2NormalizationOp(param);
+ });
+ return op;
}
// DO_BIND_DISPATCH comes from static_operator_common.h
-Operator* L2NormalizationProp::CreateOperator(Context ctx) const {
- DO_BIND_DISPATCH(CreateOp, param_);
+Operator* L2NormalizationProp::CreateOperatorEx(Context ctx,
std::vector *in_shape,
+std::vector *in_type)
const {
+ std::vector out_shape, aux_shape;
Review comment:
Do you mean the checks for InferType and InferShape?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] haojin2 commented on a change in pull request #10078: Support float16 in L2Normalization operator
haojin2 commented on a change in pull request #10078: Support float16 in
L2Normalization operator
URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r174012945
##
File path: src/operator/l2_normalization.cc
##
@@ -26,13 +26,22 @@
namespace mxnet {
namespace op {
template<>
-Operator* CreateOp(L2NormalizationParam param) {
- return new L2NormalizationOp(param);
+Operator* CreateOp(L2NormalizationParam param, int dtype) {
Review comment:
https://github.com/apache/incubator-mxnet/pull/3011/files
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] haojin2 commented on a change in pull request #10078: Support float16 in L2Normalization operator
haojin2 commented on a change in pull request #10078: Support float16 in
L2Normalization operator
URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r173943169
##
File path: src/operator/l2_normalization.cc
##
@@ -26,13 +26,18 @@
namespace mxnet {
namespace op {
template<>
-Operator* CreateOp(L2NormalizationParam param) {
- return new L2NormalizationOp(param);
+Operator* CreateOp(L2NormalizationParam param, int dtype) {
+ Operator* op = NULL;
+ MSHADOW_REAL_TYPE_SWITCH(dtype, DType, {
+op = new L2NormalizationOp(param);
+ });
+ return op;
}
// DO_BIND_DISPATCH comes from static_operator_common.h
-Operator* L2NormalizationProp::CreateOperator(Context ctx) const {
- DO_BIND_DISPATCH(CreateOp, param_);
+Operator* L2NormalizationProp::CreateOperatorEx(Context ctx,
std::vector *in_shape,
+std::vector *in_type)
const {
+ DO_BIND_DISPATCH(CreateOp, param_, in_type->at(0));
Review comment:
I see, just added calls to InferType and InferShape to the code, the PR will
be updated soon.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] haojin2 commented on a change in pull request #10078: Support float16 in L2Normalization operator
haojin2 commented on a change in pull request #10078: Support float16 in
L2Normalization operator
URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r173938378
##
File path: src/operator/l2_normalization-inl.h
##
@@ -294,7 +321,13 @@ class L2NormalizationProp : public OperatorProperty {
return {ResourceRequest::kTempSpace};
}
- Operator* CreateOperator(Context ctx) const override;
+ Operator* CreateOperator(Context ctx) const override {
Review comment:
Honestly I'm not really sure, with a simple grep for "CreateOperator" in src
only this usage appeared:
nnvm/legacy_op_util.cc:297: return
OpStatePtr::Create(prop.ptr->CreateOperatorEx(ctx, , ),
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] haojin2 commented on a change in pull request #10078: Support float16 in L2Normalization operator
haojin2 commented on a change in pull request #10078: Support float16 in
L2Normalization operator
URL: https://github.com/apache/incubator-mxnet/pull/10078#discussion_r173938378
##
File path: src/operator/l2_normalization-inl.h
##
@@ -294,7 +321,13 @@ class L2NormalizationProp : public OperatorProperty {
return {ResourceRequest::kTempSpace};
}
- Operator* CreateOperator(Context ctx) const override;
+ Operator* CreateOperator(Context ctx) const override {
Review comment:
Honestly I'm not really sure, with a simply grep for "CreateOperator" in src
only this usage appeared:
nnvm/legacy_op_util.cc:297: return
OpStatePtr::Create(prop.ptr->CreateOperatorEx(ctx, , ),
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
