[GitHub] haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True

2018-07-12 Thread GitBox
haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True URL: https://github.com/apache/incubator-mxnet/pull/11656#discussion_r202203112 ## File path: src/operator/nn/batch_norm.cc ## @@ -444,27 +445,39 @@ void Ba

[GitHub] haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True

2018-07-12 Thread GitBox
haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True URL: https://github.com/apache/incubator-mxnet/pull/11656#discussion_r202167429 ## File path: src/operator/batch_norm_v1.cc ## @@ -89,6 +89,9 @@ the output.

[GitHub] haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True

2018-07-12 Thread GitBox
haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True URL: https://github.com/apache/incubator-mxnet/pull/11656#discussion_r202165629 ## File path: tests/python/mkl/test_mkldnn.py ## @@ -233,7 +233,7 @@ def che

[GitHub] haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True

2018-07-12 Thread GitBox
haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True URL: https://github.com/apache/incubator-mxnet/pull/11656#discussion_r202128834 ## File path: tests/python/mkl/test_mkldnn.py ## @@ -233,7 +233,7 @@ def che

[GitHub] haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True

2018-07-12 Thread GitBox
haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True URL: https://github.com/apache/incubator-mxnet/pull/11656#discussion_r202122089 ## File path: tests/python/mkl/test_mkldnn.py ## @@ -233,7 +233,7 @@ def che

[GitHub] haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True

2018-07-12 Thread GitBox
haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True URL: https://github.com/apache/incubator-mxnet/pull/11656#discussion_r202116683 ## File path: tests/python/mkl/test_mkldnn.py ## @@ -233,7 +233,7 @@ def che

[GitHub] haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True

2018-07-12 Thread GitBox
haojin2 commented on a change in pull request #11656: Fix batchnorm problem with sparse matrices when fix_gamma=True URL: https://github.com/apache/incubator-mxnet/pull/11656#discussion_r202114945 ## File path: tests/python/mkl/test_mkldnn.py ## @@ -233,7 +233,7 @@ def che