jeremiedb commented on a change in pull request #9965: Fix R build crash in CI
URL: https://github.com/apache/incubator-mxnet/pull/9965#discussion_r172002855
 
 

 ##########
 File path: R-package/R/viz.graph.R
 ##########
 @@ -143,7 +142,7 @@ graph.viz <- function(symbol, shape=NULL, direction="TD", 
type="graph", graph.wi
   }
   
   graph<- create_graph(nodes_df = nodes_df_new, edges_df = edge_df_new, 
directed = TRUE) %>% 
-    set_global_graph_attrs("layout", value = "dot", attr_type = "graph") %>% 
+    add_global_graph_attrs("layout", value = "dot", attr_type = "graph") %>% 
 
 Review comment:
   Agree that I may have been too conservative with the 1.0.0 requirement. I 
just made a slight modification and graphs can now be rendered as before even 
on 0.9.0. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to