[GitHub] jverce commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-04 Thread GitBox
jverce commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222741831 ## File path: src/executor/attach_op_execs_pass.cc ## @@ -58,12 +58,10 @@ class

[GitHub] jverce commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-04 Thread GitBox
jverce commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222743110 ## File path: src/imperative/imperative.cc ## @@ -375,7 +375,9 @@ std::vector

[GitHub] jverce commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-04 Thread GitBox
jverce commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222742845 ## File path: src/imperative/cached_op.cc ## @@ -907,7 +907,7 @@ void

[GitHub] jverce commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-04 Thread GitBox
jverce commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222741979 ## File path: src/executor/graph_executor.cc ## @@ -1130,8 +1130,7 @@ void

[GitHub] jverce commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible

2018-10-04 Thread GitBox
jverce commented on a change in pull request #12356: [MXNET-860] Use modernized ranged loops where possible URL: https://github.com/apache/incubator-mxnet/pull/12356#discussion_r222742760 ## File path: src/imperative/cached_op.cc ## @@ -784,7 +784,7 @@ OpStatePtr