[GitHub] lanking520 commented on a change in pull request #13279: [MXNET-1213][WIP] add centos build for Scala

2018-11-15 Thread GitBox
lanking520 commented on a change in pull request #13279: [MXNET-1213][WIP] add 
centos build for Scala
URL: https://github.com/apache/incubator-mxnet/pull/13279#discussion_r233969582
 
 

 ##
 File path: Jenkinsfile
 ##
 @@ -698,6 +698,17 @@ core_logic: {
 }
   }
 },
+'Scala: CentOS CPU': {
+  node(NODE_LINUX_CPU) {
+ws('workspace/ut-scala-centos7-cpu') {
+  timeout(time: max_time, unit: 'MINUTES') {
+utils.unpack_and_init('centos7_cpu', mx_lib, true)
 
 Review comment:
   What diff on the files that mx_dist_lib will provide?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] lanking520 commented on a change in pull request #13279: [MXNET-1213][WIP] add centos build for Scala

2018-11-15 Thread GitBox
lanking520 commented on a change in pull request #13279: [MXNET-1213][WIP] add 
centos build for Scala
URL: https://github.com/apache/incubator-mxnet/pull/13279#discussion_r233947251
 
 

 ##
 File path: ci/docker/install/ubuntu_scala.sh
 ##
 @@ -29,12 +29,6 @@ apt-get update
 apt-get install -y openjdk-8-jdk
 apt-get install -y openjdk-8-jre
 
-echo "deb https://dl.bintray.com/sbt/debian /" | tee -a 
/etc/apt/sources.list.d/sbt.list
 
 Review comment:
   The reason to remove sbt and Scala is we don't need these components to run 
a maven project. There is Scala compiler embedded in the maven project. In that 
case, sbt and Scala installation seemed to be unnecessary


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services