[GitHub] marcoabreu commented on a change in pull request #11055: [MXNET-57] Added support android64

2018-06-12 Thread GitBox 
marcoabreu commented on a change in pull request #11055: [MXNET-57] Added 
support android64 
URL: https://github.com/apache/incubator-mxnet/pull/11055#discussion_r194963868
 
 

 ##
 File path: ci/docker/runtime_functions.sh
 ##
 @@ -163,6 +163,30 @@ build_android_arm64() {
 cp dist/*.whl /work/build
 }
 
+build_android_arm64() {
+set -ex
+cd /work/build
+#-DCMAKE_ANDROID_NDK=${CROSS_ROOT} \
+#-DCMAKE_SYSTEM_VERSION=${ANDROID_NDK_REVISION} \
+#-DCMAKE_SYSTEM_NAME=Android \
+cmake\
+-DANDROID=ON \
+-DUSE_CUDA=OFF\
+-DUSE_SSE=OFF\
+-DUSE_LAPACK=OFF\
+-DUSE_OPENCV=OFF\
+-DUSE_OPENMP=OFF\
+-DUSE_SIGNAL_HANDLER=ON\
+-DCMAKE_BUILD_TYPE=RelWithDebInfo\
 
 Review comment:
   We already spoke about this offline and I said that I'm fine with moving 
forward. Before you explaining it to me, I was under the impression that this 
would be the final stage.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcoabreu commented on a change in pull request #11055: [MXNET-57] Added support android64

2018-06-12 Thread GitBox 
marcoabreu commented on a change in pull request #11055: [MXNET-57] Added 
support android64 
URL: https://github.com/apache/incubator-mxnet/pull/11055#discussion_r194963868
 
 

 ##
 File path: ci/docker/runtime_functions.sh
 ##
 @@ -163,6 +163,30 @@ build_android_arm64() {
 cp dist/*.whl /work/build
 }
 
+build_android_arm64() {
+set -ex
+cd /work/build
+#-DCMAKE_ANDROID_NDK=${CROSS_ROOT} \
+#-DCMAKE_SYSTEM_VERSION=${ANDROID_NDK_REVISION} \
+#-DCMAKE_SYSTEM_NAME=Android \
+cmake\
+-DANDROID=ON \
+-DUSE_CUDA=OFF\
+-DUSE_SSE=OFF\
+-DUSE_LAPACK=OFF\
+-DUSE_OPENCV=OFF\
+-DUSE_OPENMP=OFF\
+-DUSE_SIGNAL_HANDLER=ON\
+-DCMAKE_BUILD_TYPE=RelWithDebInfo\
 
 Review comment:
   We already spoke about this offline and I said that I'm fine with moving 
forward.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] marcoabreu commented on a change in pull request #11055: [MXNET-57] Added support android64

2018-06-12 Thread GitBox 
marcoabreu commented on a change in pull request #11055: [MXNET-57] Added 
support android64 
URL: https://github.com/apache/incubator-mxnet/pull/11055#discussion_r194802029
 
 

 ##
 File path: ci/docker/Dockerfile.build.android_arm64
 ##
 @@ -18,23 +18,20 @@
 #
 # Dockerfile to build MXNet for Android ARM64/ARMv8
 
-FROM ubuntu:16.04 as ccachebuilder
-
-COPY install/ubuntu_core.sh /work/
-RUN /work/ubuntu_core.sh
-COPY install/ubuntu_ccache.sh /work/
-RUN /work/ubuntu_ccache.sh
+#FROM ubuntu:16.04 as ccachebuilder
+#COPY install/ubuntu_core.sh /work/
+#RUN /work/ubuntu_core.sh
+#COPY install/ubuntu_ccache.sh /work/
+#RUN /work/ubuntu_ccache.sh
 
 Review comment:
   Could you elaborate?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services