[GitHub] marcoabreu commented on issue #11650: remove windows note for dataloader, fix deprecated warning in python3.7
marcoabreu commented on issue #11650: remove windows note for dataloader, fix deprecated warning in python3.7 URL: https://github.com/apache/incubator-mxnet/pull/11650#issuecomment-404310386 Okay, can we then remove the print to reduce the log output and replace it with some no-op? We're already having a lot of useless log (stuff like a function printing the numbers from 1 to 1) and I'd like to keep that low in future if the log messages don't provide any information about the test itself. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #11650: remove windows note for dataloader, fix deprecated warning in python3.7
marcoabreu commented on issue #11650: remove windows note for dataloader, fix deprecated warning in python3.7 URL: https://github.com/apache/incubator-mxnet/pull/11650#issuecomment-404270491 Definitely! My question is whether we test the data loader on windows. Sometimes, we have some conditional skips if we run on windows. It would be great if we could verify that this test is actually run on windows. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] marcoabreu commented on issue #11650: remove windows note for dataloader, fix deprecated warning in python3.7
marcoabreu commented on issue #11650: remove windows note for dataloader, fix deprecated warning in python3.7 URL: https://github.com/apache/incubator-mxnet/pull/11650#issuecomment-404268059 Great! Is this covered by tests or do we maybe have a skip defined somewhere? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
