[GitHub] marcoabreu commented on issue #11669: Fix TabError for Python 3

2018-07-13 Thread GitBox
marcoabreu commented on issue #11669: Fix TabError for Python 3
URL: https://github.com/apache/incubator-mxnet/pull/11669#issuecomment-404758427
 
 
   Sorry, we just waited for CI to pass :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] marcoabreu commented on issue #11669: Fix TabError for Python 3

2018-07-12 Thread GitBox
marcoabreu commented on issue #11669: Fix TabError for Python 3
URL: https://github.com/apache/incubator-mxnet/pull/11669#issuecomment-404591153
 
 
   Excellent, thanks a lot for this detailed answer! This definitely sounds 
like a good approach, do you think it would be possible to request adding it to 
your teams long term planning - maybe as part of Q3 and the efforts to resolve 
the example related issues? I think a lot of these issues are based on the fact 
that we don't have proper test coverage for them.
   
   We could basically start with an example and create a small guide. Then we'd 
make a quick sprint where everybody takes one example and adds it to CI in 
accordance with your instructions.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] marcoabreu commented on issue #11669: Fix TabError for Python 3

2018-07-12 Thread GitBox
marcoabreu commented on issue #11669: Fix TabError for Python 3
URL: https://github.com/apache/incubator-mxnet/pull/11669#issuecomment-404572358
 
 
   @ThomasDelteil any chance you guys can squeeze in example validation 
together with the tutorial validation? We're having a lot of problems in our 
examples that are hidden because we don't test them.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services