[GitHub] marcoabreu commented on issue #9771: Modify NDArrayIter constructor to receive tuple (i.e. dict in Python)?

2018-02-14 Thread GitBox
marcoabreu commented on issue #9771: Modify NDArrayIter constructor to receive tuple (i.e. dict in Python)? URL: https://github.com/apache/incubator-mxnet/pull/9771#issuecomment-365535322 @nswamy do you have an idea? This is

[GitHub] marcoabreu commented on issue #9771: Modify NDArrayIter constructor to receive tuple (i.e. dict in Python)?

2018-02-13 Thread GitBox
marcoabreu commented on issue #9771: Modify NDArrayIter constructor to receive tuple (i.e. dict in Python)? URL: https://github.com/apache/incubator-mxnet/pull/9771#issuecomment-365223393 Your change has the following issues, not providing backwards compatibility: ``` Type change: dat

[GitHub] marcoabreu commented on issue #9771: Modify NDArrayIter constructor to receive tuple (i.e. dict in Python)?

2018-02-13 Thread GitBox
marcoabreu commented on issue #9771: Modify NDArrayIter constructor to receive tuple (i.e. dict in Python)? URL: https://github.com/apache/incubator-mxnet/pull/9771#issuecomment-365201632 Since we are using semantic versioning, this would require a major version update. Thus, this change

[GitHub] marcoabreu commented on issue #9771: Modify NDArrayIter constructor to receive tuple (i.e. dict in Python)?

2018-02-12 Thread GitBox
marcoabreu commented on issue #9771: Modify NDArrayIter constructor to receive tuple (i.e. dict in Python)? URL: https://github.com/apache/incubator-mxnet/pull/9771#issuecomment-365043493 Please consider adding an additional constructor instead of modifying the existing constructor to prov