[GitHub] marcoabreu commented on issue #9791: CI test randomness 3

2018-02-18 Thread GitBox
marcoabreu commented on issue #9791: CI test randomness 3 URL: https://github.com/apache/incubator-mxnet/pull/9791#issuecomment-366530518 @DickJC123 would you mind creating another PR which adds documentation for these features? Good places could be the readme in the tests dir or

[GitHub] marcoabreu commented on issue #9791: CI test randomness 3

2018-02-17 Thread GitBox
marcoabreu commented on issue #9791: CI test randomness 3 URL: https://github.com/apache/incubator-mxnet/pull/9791#issuecomment-366429224 Approved for merge. Please resolve the test failure if possible. This is an automated

[GitHub] marcoabreu commented on issue #9791: CI test randomness 3

2018-02-16 Thread GitBox
marcoabreu commented on issue #9791: CI test randomness 3 URL: https://github.com/apache/incubator-mxnet/pull/9791#issuecomment-366204903 I'd like to see this feature and the stated assumptions being tested, but otherwise it LGTM.

[GitHub] marcoabreu commented on issue #9791: CI test randomness 3

2018-02-14 Thread GitBox
marcoabreu commented on issue #9791: CI test randomness 3 URL: https://github.com/apache/incubator-mxnet/pull/9791#issuecomment-365594780 Would it be possible to write a test for this feature? Especially around the ``with random_seed():``

[GitHub] marcoabreu commented on issue #9791: CI test randomness 3

2018-02-14 Thread GitBox
marcoabreu commented on issue #9791: CI test randomness 3 URL: https://github.com/apache/incubator-mxnet/pull/9791#issuecomment-365594449 ``` == FAIL: test_operator.test_rcbrt_op

[GitHub] marcoabreu commented on issue #9791: CI test randomness 3

2018-02-14 Thread GitBox
marcoabreu commented on issue #9791: CI test randomness 3 URL: https://github.com/apache/incubator-mxnet/pull/9791#issuecomment-365562226 Very nice feature, thanks a lot for putting so much effort into this! This is an