[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

2018-03-01 Thread GitBox
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-369555038 Thanks a lot everybody! This is an automated

[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

2018-02-22 Thread GitBox
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367872237 Would it be possible to create a test that introduces a delay or uses a for-loop in order to force this race

[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

2018-02-22 Thread GitBox
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367872237 Would it be possible to create a test that introduces a delay in order to force this race condition?

[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

2018-02-22 Thread GitBox
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367866215 I'm afraid I still don't really understand. I see that you have re-enabled this test, but unfortunately I'm

[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

2018-02-22 Thread GitBox
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367865250 We don't need fixed seeds since #9791 has been merged. Just make sure that the with_seed decorator is properly

[GitHub] marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN.

2018-02-22 Thread GitBox
marcoabreu commented on issue #9862: Fix a race condition in converting data layouts in MKLDNN. URL: https://github.com/apache/incubator-mxnet/pull/9862#issuecomment-367850610 But would this re-enabled test have caught this error? Please explain how we're preventing this problem from