[GitHub] mbaijal commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check
mbaijal commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check URL: https://github.com/apache/incubator-mxnet/pull/10390#discussion_r179268703 ## File path: tests/nightly/apache_rat_license_check/.rat-excludes ## @@ -0,0 +1,54 @@ +.*xml +\..* +.*css +\\.* +.*ipynb +.*html +.*json +.*js +.*txt +.*md +3rdparty/* +R-package/* +src/operator/mkl/* +trunk/* +docker/* +docker_multiarch/* +.*\\.m +.*\\.mk +.*\\.R +contrib/* Review comment: I dont think contrib can have the apache header. Again, I am not sure what the best way to handle these is This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mbaijal commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check
mbaijal commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check URL: https://github.com/apache/incubator-mxnet/pull/10390#discussion_r179268483 ## File path: tests/nightly/apache_rat_license_check/.rat-excludes ## @@ -0,0 +1,54 @@ +.*xml +\..* +.*css +\\.* +.*ipynb +.*html +.*json +.*js +.*txt +.*md +3rdparty/* +R-package/* +src/operator/mkl/* +trunk/* +docker/* +docker_multiarch/* +.*\\.m +.*\\.mk +.*\\.R +contrib/* +Dockerfile* +.*svg +.*cfg +.*config +docs/* +__init__.py +build/* +.*\\.t +perl-package/* Review comment: Yea, these are packages I am not sure about the licensing, I have added details here - https://cwiki.apache.org/confluence/display/MXNET/MXNet+Source+Licenses This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mbaijal commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check
mbaijal commented on a change in pull request #10390: [WIP] Initial PR for RAT License Check URL: https://github.com/apache/incubator-mxnet/pull/10390#discussion_r179245499 ## File path: tests/nightly/apache_rat_license_check/README.md ## @@ -0,0 +1,36 @@ +# Apache RAT License Check + +This is a nightly test that runs the Apache Tool RAT to check the License Headers on all source files + +### The .rat-excludes file +This file lists all the files, directories and file formats that are excluded from license checks for various reasons. +If you think something is wrong, feel free to change! + +### Nightly test script for license check +Coming soon... + +### How to run the RAT check locally +The following commands can be used to run a Apache RAT check locally - Review comment: Yes, a script is coming with the nightly tests This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
