[GitHub] mbaijal commented on a change in pull request #10390: Initial PR for RAT License Check
mbaijal commented on a change in pull request #10390: Initial PR for RAT License Check URL: https://github.com/apache/incubator-mxnet/pull/10390#discussion_r180626838 ## File path: tests/nightly/apache_rat_license_check/.rat-excludes ## @@ -0,0 +1,54 @@ +.*xml +\..* +.*css +\\.* +.*ipynb +.*html +.*json +.*js +.*txt +.*md +3rdparty/* +R-package/* +src/operator/mkl/* +trunk/* +docker/* +docker_multiarch/* +.*\\.m +.*\\.mk +.*\\.R +contrib/* Review comment: @eric-haibin-lin, see my comment at the end of this PR. I do not want to add wrong licenses to any files and hence have left these files as is until I am sure they can have the ASF header. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mbaijal commented on a change in pull request #10390: Initial PR for RAT License Check
mbaijal commented on a change in pull request #10390: Initial PR for RAT License Check URL: https://github.com/apache/incubator-mxnet/pull/10390#discussion_r180267135 ## File path: tests/nightly/apache_rat_license_check/.rat-excludes ## @@ -0,0 +1,54 @@ +.*xml +\..* +.*css +\\.* +.*ipynb +.*html +.*json +.*js +.*txt +.*md +3rdparty/* +R-package/* +src/operator/mkl/* +trunk/* +docker/* +docker_multiarch/* +.*\\.m +.*\\.mk +.*\\.R +contrib/* +Dockerfile* +.*svg +.*cfg +.*config +docs/* +__init__.py +build/* +.*\\.t +perl-package/* Review comment: The following 13 files in the perl-package do not have a valid license - /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-MXNet/Changes /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-MXNet/MANIFEST /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-MXNet/META.yml /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-MXNetCAPI/Changes /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-MXNetCAPI/MANIFEST /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-MXNetCAPI/META.yml /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-MXNetCAPI/mxnet.i /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-MXNetCAPI/mxnet_typemaps.i /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-NNVMCAPI/Changes /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-NNVMCAPI/MANIFEST /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-NNVMCAPI/META.yml /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-NNVMCAPI/nnvm.i /home/ubuntu/workspace/RAT_LicenseCheck/perl-package/AI-NNVMCAPI/nnvm_typemaps.i Do you know who can resolve this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
