nswamy commented on a change in pull request #11681: [MXNET-531] improvement of adding source.jar to assembly URL: https://github.com/apache/incubator-mxnet/pull/11681#discussion_r202213261
########## File path: scala-package/assembly/src/source.xml ########## @@ -0,0 +1,32 @@ +<assembly xmlns="http://maven.apache.org/ASSEMBLY/2.0.0"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/ASSEMBLY/2.0.0 http://maven.apache.org/xsd/assembly-2.0.0.xsd";> + <id>src</id> + <!--This is the source jar generation config--> + <formats> + <format>jar</format> + </formats> + <includeBaseDirectory>false</includeBaseDirectory> + <moduleSets> + <moduleSet> + <useAllReactorProjects>true</useAllReactorProjects> + <includes> + <!--Please put your module defs here--> + <include>org.apache.mxnet:mxnet-core_${scala.binary.version}</include> Review comment: note to self: add infer package after pom-flle updates for maven publish ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
