[GitHub] nswamy commented on issue #9858: softsign activation function
nswamy commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367872369 I am closing this PR. Customer is ok to apply the patch on v.0.11. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nswamy commented on issue #9858: softsign activation function
nswamy commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367859595 I am ok to put it to all the releases after 0.11.0 upto master, but I don't think it has to be done right away. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nswamy commented on issue #9858: softsign activation function
nswamy commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367855882 Ok, I registered the symbol under contrib. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nswamy commented on issue #9858: softsign activation function
nswamy commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367788415 @piiswrong @szha Some background: One of the customer is using MXNet-Scala Interface of 0.11 version. They are soon to go live with their product(in the next 2 weeks), they use a CustomOp to perform Softsign in which I and @yzhliu suspect the leak to be coming from. We spent quite a bit of time trying to analyze the code and debug the issue, however we haven't been able to nail down where it is coming from. In order to help the customer launch their product, I am providing this activation function on 0.11. I understand this does not follow semver, etc., The customer has been very patiently working with me and Yizhi and I see it as a big win for MXNet. They certainly want to upgrade their MXNet to the latest but not before their product launch. I hope that makes sense. @szha, the reason to have this as a separate commit is that the activation function has gone through some refactor, so cherry picking does not work for this. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] nswamy commented on issue #9858: softsign activation function
nswamy commented on issue #9858: softsign activation function URL: https://github.com/apache/incubator-mxnet/pull/9858#issuecomment-367542143 @cjolivier01 @anirudh2290 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
