[GitHub] rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag for CI

[GitBox]

rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag 
for CI
URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-378953781
 
 
   But mxlib is used for other builds which won't have these files. We haven't
   enabled dist_kvstore flag for all builds.
   
   On Thu, Apr 5, 2018, 3:45 AM Marco de Abreu 
   wrote:
   
   > *@marcoabreu* commented on this pull request.
   > --
   >
   > In Jenkinsfile
   > 

   > :
   >
   > > @@ -164,7 +166,7 @@ try {
   >  ws('workspace/build-cpu-openblas') {
   >init_git()
   >sh "ci/build.py --platform ubuntu_cpu 
/work/runtime_functions.sh build_ubuntu_cpu_openblas"
   > -  pack_lib('cpu')
   > +  pack_lib('cpu', mx_dist_lib)
   >
   > Sorry, that's the wrong approach :/ Could you please extend mx_lib
   > instead of adding mx_dist_lib and create a new PR @rahul003
   > ?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag for CI

[GitBox]

rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag 
for CI
URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-378726983
 
 
   @marcoabreu This is ready to be merged!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag for CI

[GitBox]

rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag 
for CI
URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-378682112
 
 
   I'm confused which build in the build phase, is used by the scala build


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag for CI

[GitBox]

rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag 
for CI
URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-378682112
 
 
   I'm confused which build in the build phase, is used by the scala build


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag for CI

[GitBox]

rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag 
for CI
URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-378679933
 
 
   ```
   work/mxnet/3rdparty/ps-lite/build/libps.a: No such file or directory
   work/mxnet/deps/lib/libprotobuf-lite.a: No such file or directory
   work/mxnet/deps/lib/libzmq.a: No such file or directory
   ```


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag for CI

[GitBox]

rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag 
for CI
URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-378679297
 
 
   The scala build (in unit test phase) links with couple of libraries it looks 
like, which aren't available. I believe we need to stash the libraries after 
the build phase and unstash them here. Right? Could you look at the latest 
build failure?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag for CI

[GitBox]

rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag 
for CI
URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-376696411
 
 
   @marcoabreu Actually none of the tests we have right now require 
USE_DIST_KVSTORE to be built. And building it with this flag wouldn't affect 
any of those tests. It just builds two additional files 
src/kvstore/kvstore_dist , src/kvstore/kvstore_dist_server and the submodule 
ps-lite.
   USE_DIST_KVSTORE is an additional feature to run distributed training across 
multiple machines. This is not tested in our CI currently, because it is 
complicated to setup. It is required for some nightly tests we run though. 
   ps-lite is exclusively used for distributed training, so that too would not 
affect any of these tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag for CI

[GitBox]

rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag 
for CI
URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-376394320
 
 
   Updating ps-lite is necessary as the latest commit there has the fix for 
build issue with cmake versions before 3.6
   
   Ref: https://github.com/dmlc/ps-lite/pull/130


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag for CI

[GitBox]

rahul003 commented on issue #10232: [MXNET-136] Enabling USE_DIST_KVSTORE flag 
for CI
URL: https://github.com/apache/incubator-mxnet/pull/10232#issuecomment-376394178
 
 
   @marcoabreu This is ready to be merged IMO. Please take a look


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services