[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-18 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-382488353 Can we close this now? This is an automated message from the Apache Git Service. T

[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380997060 Dot for fp16 on GPU was supported internally but a (probably older) CHECK was blocking it. Created a PR to fix this. https://github.com/apac

[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380977138 Removing my earlier comment. Actually float16 dot does seem supported for GPU. What error did you encounter? --

[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380977138 Removing my earlier comment. Actually float16 dot does seem supported for GPU. What error did you encounter? --

[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380956997 @haojin2 Looks like we missed this. I went through dot-inl.h. Looks like that's disabled for no reason the GPU through the check. Could you take a

[GitHub] rahul003 commented on issue #10531: Float16 Support for dot

2018-04-12 Thread GitBox
rahul003 commented on issue #10531: Float16 Support for dot URL: https://github.com/apache/incubator-mxnet/issues/10531#issuecomment-380956997 @haojin2 Looks like we missed this. I went through dot-inl.h. Looks like that's disabled for no reason the GPU through the check. Could you take a