[GitHub] reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-12 Thread GitBox
reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#discussion_r181131835 ## File path: python/mxnet/module/base_module.py ## @@ -78,6 +81,35 @@ def

[GitHub] reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-12 Thread GitBox
reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#discussion_r181136501 ## File path: tests/python/unittest/test_io.py ## @@ -313,6 +313,20 @@ def

[GitHub] reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-11 Thread GitBox
reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#discussion_r180856241 ## File path: python/mxnet/module/base_module.py ## @@ -268,6 +285,10 @@ def score(self, eval_data,

[GitHub] reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-11 Thread GitBox
reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#discussion_r180851936 ## File path: python/mxnet/module/base_module.py ## @@ -364,6 +385,22 @@ def predict(self,

[GitHub] reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-11 Thread GitBox
reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#discussion_r180856808 ## File path: python/mxnet/module/base_module.py ## @@ -374,6 +411,10 @@ def predict(self,

[GitHub] reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-11 Thread GitBox
reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#discussion_r180852645 ## File path: python/mxnet/io.py ## @@ -506,6 +507,7 @@ def _init_data(data, allow_empty,

[GitHub] reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-11 Thread GitBox
reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#discussion_r180854421 ## File path: python/mxnet/module/base_module.py ## @@ -244,6 +245,22 @@ def score(self, eval_data,

[GitHub] reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix

2018-04-11 Thread GitBox
reminisce commented on a change in pull request #10425: [MXNET-175] NdArrayiterator dict fix URL: https://github.com/apache/incubator-mxnet/pull/10425#discussion_r180851470 ## File path: python/mxnet/module/base_module.py ## @@ -364,6 +385,22 @@ def predict(self,