[GitHub] sergeykolychev commented on issue #10460: MXNET-295 [Perl] Added support for linalg operators.

[GitBox]

sergeykolychev commented on issue #10460: MXNET-295 [Perl] Added support for 
linalg operators.
URL: https://github.com/apache/incubator-mxnet/pull/10460#issuecomment-379821889
 
 
   Got it, thank you Marco. I'll make a rule to wait at least 72 hours before
   merging (approval from perl contributors and tests pass assumed as well).
   
   On Mon, Apr 9, 2018 at 9:44 AM, Marco de Abreu 
   wrote:
   
   > I think @nswamy  knows Perl, right?
   >
   > I definitely see your point and appreciate that you don't want to bother
   > others, but I don't think a bit of peer-reviewing is going to totally fine
   > - even if it's being by people who are not familiar with the language
   > itself. If there's really no way to get somebody to verify your PR, I'd
   > suggest the Apache approach about their rules for lazy-votes. If nobody
   > objects within 72h hours, you're free to move on without further approval.
   >
   > Please don't misunderstand me, this is no criticism about your skills or
   > anything, I just think we should give some time to the community to have a
   > quick look and point out possible concerns our users and developers have.
   > Of course, you always have the liberty to merge critical PRs yourself
   > immediately.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sergeykolychev commented on issue #10460: MXNET-295 [Perl] Added support for linalg operators.

[GitBox]

sergeykolychev commented on issue #10460: MXNET-295 [Perl] Added support for 
linalg operators.
URL: https://github.com/apache/incubator-mxnet/pull/10460#issuecomment-379821889
 
 
   Got it, thank you Mark. I'll make a rule to wait at least 72 hours before
   merging (approval from perl contributors and tests pass assumed as well).
   
   On Mon, Apr 9, 2018 at 9:44 AM, Marco de Abreu 
   wrote:
   
   > I think @nswamy  knows Perl, right?
   >
   > I definitely see your point and appreciate that you don't want to bother
   > others, but I don't think a bit of peer-reviewing is going to totally fine
   > - even if it's being by people who are not familiar with the language
   > itself. If there's really no way to get somebody to verify your PR, I'd
   > suggest the Apache approach about their rules for lazy-votes. If nobody
   > objects within 72h hours, you're free to move on without further approval.
   >
   > Please don't misunderstand me, this is no criticism about your skills or
   > anything, I just think we should give some time to the community to have a
   > quick look and point out possible concerns our users and developers have.
   > Of course, you always have the liberty to merge critical PRs yourself
   > immediately.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sergeykolychev commented on issue #10460: MXNET-295 [Perl] Added support for linalg operators.

[GitBox]

sergeykolychev commented on issue #10460: MXNET-295 [Perl] Added support for 
linalg operators.
URL: https://github.com/apache/incubator-mxnet/pull/10460#issuecomment-379813398
 
 
   I will if you request so, unfortunately there's no other committer with
   Perl knowledge afaik (the PR was approved by another Perl contributor).
   In fact I requested the committer right in order to not bother members with
   small changes to perl only space that do not depend on new additions to C++
   api (this one certainly qualifies as such)
   Who would you suggest I'll be asking in the future to merge my PRs assuming
   they pass the tests and approved by perl contributors ?
   
   On Mon, Apr 9, 2018 at 9:15 AM, Marco de Abreu 
   wrote:
   
   > @sergeykolychev  could you please
   > refrain from self-merging as agreed on in the community and wait for
   > another committer if the PR is not urgent?
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or mute the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sergeykolychev commented on issue #10460: MXNET-295 [Perl] Added support for linalg operators.

[GitBox]

sergeykolychev commented on issue #10460: MXNET-295 [Perl] Added support for 
linalg operators.
URL: https://github.com/apache/incubator-mxnet/pull/10460#issuecomment-379581976
 
 
   @tlby Rob, please check it out


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services