[GitHub] szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master
szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master URL: https://github.com/apache/incubator-mxnet/pull/8704#discussion_r153105761 ## File path: docs/build_version_doc/build_all_version.sh ## @@ -21,7 +21,7 @@ # Built files are stored in $built # Version numbers are stored in $tag_list. # Version numbers are ordered from latest to old and final one is master. -tag_list="0.12.0 0.11.0 master" +tag_list="1.0.0 0.12.0 0.11.0 master" Review comment: @piiswrong after @mbaijal updates the tag list, this PR won't involve any change that needs the 1.0.0 tag. In addition, current nightly builds are still released as 0.12.1beta versions because this PR is blocked. Could we merge this PR after @mbaijal makes the update, to resolve the nightly build situation? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master
szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master URL: https://github.com/apache/incubator-mxnet/pull/8704#discussion_r153105656 ## File path: setup-utils/install-mxnet-osx-python.sh ## @@ -33,7 +33,7 @@ then # TODO: Change this to latest tag # to avoid updating this value for every release # - export MXNET_TAG="0.12.0" + export MXNET_TAG="1.0.0" Review comment: @mbaijal same, please update. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master
szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master URL: https://github.com/apache/incubator-mxnet/pull/8704#discussion_r153105628 ## File path: docs/build_version_doc/build_all_version.sh ## @@ -21,7 +21,7 @@ # Built files are stored in $built # Version numbers are stored in $tag_list. # Version numbers are ordered from latest to old and final one is master. -tag_list="0.12.0 0.11.0 master" +tag_list="1.0.0 0.12.0 0.11.0 master" Review comment: @mbaijal would you please update the tag with 0.12.1? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master
szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master URL: https://github.com/apache/incubator-mxnet/pull/8704#discussion_r152120073 ## File path: docs/build_version_doc/build_all_version.sh ## @@ -21,7 +21,7 @@ # Built files are stored in $built # Version numbers are stored in $tag_list. # Version numbers are ordered from latest to old and final one is master. -tag_list="0.12.0 0.11.0 master" +tag_list="1.0.0 0.12.0 0.11.0 master" Review comment: Yes. Currently we are still developing on a version number that already has a release, so it needs to be bumped up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master
szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master URL: https://github.com/apache/incubator-mxnet/pull/8704#discussion_r151907672 ## File path: docs/build_version_doc/build_all_version.sh ## @@ -21,7 +21,7 @@ # Built files are stored in $built # Version numbers are stored in $tag_list. # Version numbers are ordered from latest to old and final one is master. -tag_list="0.12.0 0.11.0 master" +tag_list="1.0.0 0.12.0 0.11.0 master" Review comment: 1.0.0 is not available yet. 0.12.1 should be added instead. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master
szha commented on a change in pull request #8704: Initial Prep for 1.0: bump up version and add 0.12.1 changes to master URL: https://github.com/apache/incubator-mxnet/pull/8704#discussion_r151907710 ## File path: setup-utils/install-mxnet-osx-python.sh ## @@ -33,7 +33,7 @@ then # TODO: Change this to latest tag # to avoid updating this value for every release # - export MXNET_TAG="0.12.0" + export MXNET_TAG="1.0.0" Review comment: 0.12.1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
