[GitHub] szha commented on issue #10385: allow user to define unknown token symbol

2018-04-09 Thread GitBox
szha commented on issue #10385: allow user to define unknown token symbol
URL: https://github.com/apache/incubator-mxnet/pull/10385#issuecomment-379824086
 
 
   @marcoabreu see #10461 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] szha commented on issue #10385: allow user to define unknown token symbol

2018-04-08 Thread GitBox
szha commented on issue #10385: allow user to define unknown token symbol
URL: https://github.com/apache/incubator-mxnet/pull/10385#issuecomment-379570094
 
 
   You can add the test cases to 
https://github.com/apache/incubator-mxnet/blob/master/tests/python/unittest/test_rnn.py,
 run it locally to make sure it passes, and submit the change as part of your 
PR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services