[GitHub] szha commented on issue #8689: Mark tests that should only be run nightly.

2017-11-19 Thread GitBox
szha commented on issue #8689: Mark tests that should only be run nightly. URL: https://github.com/apache/incubator-mxnet/pull/8689#issuecomment-345609106 @KellenSunderland please rebase and resolve conflict. This is an

[GitHub] szha commented on issue #8689: Mark tests that should only be run nightly.

2017-11-17 Thread GitBox
szha commented on issue #8689: Mark tests that should only be run nightly. URL: https://github.com/apache/incubator-mxnet/pull/8689#issuecomment-345338868 @KellenSunderland thanks. The information you collected in this PR while analyzing the tests are valuable. It would be great if we

[GitHub] szha commented on issue #8689: Mark tests that should only be run nightly.

2017-11-17 Thread GitBox
szha commented on issue #8689: Mark tests that should only be run nightly. URL: https://github.com/apache/incubator-mxnet/pull/8689#issuecomment-345336009 I understand the motivation for moving tests to nightly. The concern I still have is if we disable certain tests on PR-level and only