[GitHub] tlby commented on a change in pull request #9988: [Perl] Sparse feature.

2018-03-07 Thread GitBox
tlby commented on a change in pull request #9988: [Perl] Sparse feature. URL: https://github.com/apache/incubator-mxnet/pull/9988#discussion_r172895513 ## File path: perl-package/AI-MXNet/lib/AI/MXNet/NDArray/Sparse.pm ## @@ -0,0 +1,1342 @@ +# Licensed to the Apache

[GitHub] tlby commented on a change in pull request #9988: [Perl] Sparse feature.

2018-03-06 Thread GitBox
tlby commented on a change in pull request #9988: [Perl] Sparse feature. URL: https://github.com/apache/incubator-mxnet/pull/9988#discussion_r172571957 ## File path: perl-package/AI-MXNetCAPI/mxnet_typemaps.i ## @@ -112,6 +112,32 @@ } } +%typemap(in,numinputs=0)

[GitHub] tlby commented on a change in pull request #9988: [Perl] Sparse feature.

2018-03-05 Thread GitBox
tlby commented on a change in pull request #9988: [Perl] Sparse feature. URL: https://github.com/apache/incubator-mxnet/pull/9988#discussion_r172401798 ## File path: perl-package/AI-MXNet/lib/AI/MXNet/Optimizer.pm ## @@ -398,6 +423,461 @@ method update(

[GitHub] tlby commented on a change in pull request #9988: [Perl] Sparse feature.

2018-03-05 Thread GitBox
tlby commented on a change in pull request #9988: [Perl] Sparse feature. URL: https://github.com/apache/incubator-mxnet/pull/9988#discussion_r172403304 ## File path: perl-package/AI-MXNet/lib/AI/MXNet/NDArray/Sparse.pm ## @@ -0,0 +1,1342 @@ +# Licensed to the Apache

[GitHub] tlby commented on a change in pull request #9988: [Perl] Sparse feature.

2018-03-05 Thread GitBox
tlby commented on a change in pull request #9988: [Perl] Sparse feature. URL: https://github.com/apache/incubator-mxnet/pull/9988#discussion_r172405674 ## File path: perl-package/AI-MXNetCAPI/mxnet_typemaps.i ## @@ -112,6 +112,32 @@ } } +%typemap(in,numinputs=0)

[GitHub] tlby commented on a change in pull request #9988: [Perl] Sparse feature.

2018-03-05 Thread GitBox
tlby commented on a change in pull request #9988: [Perl] Sparse feature. URL: https://github.com/apache/incubator-mxnet/pull/9988#discussion_r172404489 ## File path: perl-package/AI-MXNet/lib/AI/MXNet/Base.pm ## @@ -365,4 +452,20 @@ $PDL::toolongtoprint = 1000_000_000;

[GitHub] tlby commented on a change in pull request #9988: [Perl] Sparse feature.

2018-03-05 Thread GitBox
tlby commented on a change in pull request #9988: [Perl] Sparse feature. URL: https://github.com/apache/incubator-mxnet/pull/9988#discussion_r172401998 ## File path: perl-package/AI-MXNet/lib/AI/MXNet/IO.pm ## @@ -459,20 +459,33 @@ sub BUILD my $self = shift; my