xinyu-intel commented on a change in pull request #10578: [MXNET-326] fix filter layout in DepthwiseConv2dBackwardFilterKernel URL: https://github.com/apache/incubator-mxnet/pull/10578#discussion_r181951761
########## File path: src/operator/nn/depthwise_convolution_tf.cuh ########## @@ -450,14 +453,17 @@ DepthwiseConv2dBackwardFilterKernel(const DepthwiseArgs args, const int input_offset_temp = (out_b * in_channel * in_height * in_width) + (in_c * in_height * in_width) + (in_row * in_width); + const int filter_backprop_temp = + (in_channel * filter_width * filter_height) + + (filter_width * f_h); CUDA_UNROLL for (int f_w = 0; f_w < filter_width; ++f_w) { const int in_col = in_col_start + f_w; const int addr_temp = filter_width * f_h; Review comment: It seems that variable `addr_temp` was declared but never referenced. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services