[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-14 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r195511194 ## File path: src/common/exec_utils.h ## @@ -98,10 +98,13 @@ inline bool SetupDefaultB

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-13 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r195148473 ## File path: src/common/exec_utils.h ## @@ -98,10 +98,13 @@ inline bool SetupDefaultB

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-13 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r195152303 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -128,12 +201,18 @@ void Comm

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194900964 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -571,9 +613,8 @@ void VerifyActResult

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194812866 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -304,18 +383,26 @@ void Fall

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194810836 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -128,12 +201,18 @@ void Comm

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194813020 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -304,18 +383,26 @@ void Fall

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194813504 ## File path: src/operator/nn/mkldnn/mkldnn_sum.cc ## @@ -58,46 +58,54 @@ void MKLDNNS

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194814080 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -582,12 +623,20 @@ void VerifySumResu

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194814020 ## File path: tests/cpp/operator/mkldnn.cc ## @@ -571,9 +613,8 @@ void VerifyActResult

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194808938 ## File path: src/common/exec_utils.h ## @@ -98,10 +98,13 @@ inline bool SetupDefaultB

[GitHub] zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators

2018-06-12 Thread GitBox
zheng-da commented on a change in pull request #11129: [MXNET-497]Test kAddTo request for mkldnn operators URL: https://github.com/apache/incubator-mxnet/pull/11129#discussion_r194811728 ## File path: src/operator/nn/mkldnn/mkldnn_base.cc ## @@ -304,18 +383,26 @@ void Fall