[GitHub] utzig commented on issue #1516: add bluepill stm32f103c8 support

2018-11-16 Thread GitBox
utzig commented on issue #1516: add bluepill stm32f103c8 support URL: https://github.com/apache/mynewt-core/pull/1516#issuecomment-439344216 There is no cookbook manual for configuring the `stm32YYxx_hal_conf.h` file but usually we disable all non-used modules. You could take a look at

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234144177 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234146746 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234147553 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234147288 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] utzig commented on issue #1516: add bluepill stm32f103c8 support

2018-11-16 Thread GitBox
utzig commented on issue #1516: add bluepill stm32f103c8 support URL: https://github.com/apache/mynewt-core/pull/1516#issuecomment-439358130 Just to be clear what I meant by "This is not that important because it only slows down the build times slightly." is that it is not that important

[GitHub] apache-mynewt-bot removed a comment on issue #1489: Nucleo-F072RB

2018-11-16 Thread GitBox
apache-mynewt-bot removed a comment on issue #1489: Nucleo-F072RB URL: https://github.com/apache/mynewt-core/pull/1489#issuecomment-439209392 ## RAT Report (2018-11-15 22:12:47) ## New files with unknown licenses *

[GitHub] apache-mynewt-bot commented on issue #1489: Nucleo-F072RB

2018-11-16 Thread GitBox
apache-mynewt-bot commented on issue #1489: Nucleo-F072RB URL: https://github.com/apache/mynewt-core/pull/1489#issuecomment-439345904 ## RAT Report (2018-11-16 10:10:49) ## New files with unknown licenses *

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234148399 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234151068 ## File path: hw/bus/spi/src/spi.c ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234143032 ## File path: hw/drivers/sensors/bme280/src/bme280.c ## @@ -826,9 +830,21 @@ int bme280_readlen(struct

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234144300 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on issue #1516: add bluepill stm32f103c8 support

2018-11-16 Thread GitBox
mkiiskila commented on issue #1516: add bluepill stm32f103c8 support URL: https://github.com/apache/mynewt-core/pull/1516#issuecomment-439354209 In theory you could make the hal_conf.h setting be dependent on the BSP config options. In practice, it's going to create a lot of messy code,

[GitHub] mkiiskila commented on issue #1516: add bluepill stm32f103c8 support

2018-11-16 Thread GitBox
mkiiskila commented on issue #1516: add bluepill stm32f103c8 support URL: https://github.com/apache/mynewt-core/pull/1516#issuecomment-439361117 Yes; painful to maintain. I agree. And you're right regarding link time garbage collection; if the init call to HAL from within BSP is

[GitHub] apache-mynewt-bot removed a comment on issue #1516: add bluepill stm32f103c8 support

2018-11-16 Thread GitBox
apache-mynewt-bot removed a comment on issue #1516: add bluepill stm32f103c8 support URL: https://github.com/apache/mynewt-core/pull/1516#issuecomment-439270540 ## RAT Report (2018-11-16 03:28:07) ## New files with unknown licenses *

[GitHub] apache-mynewt-bot commented on issue #1516: add bluepill stm32f103c8 support

2018-11-16 Thread GitBox
apache-mynewt-bot commented on issue #1516: add bluepill stm32f103c8 support URL: https://github.com/apache/mynewt-core/pull/1516#issuecomment-439415249 ## RAT Report (2018-11-16 14:46:44) ## New files with unknown licenses *

[GitHub] zerog2k commented on issue #1516: add bluepill stm32f103c8 support

2018-11-16 Thread GitBox
zerog2k commented on issue #1516: add bluepill stm32f103c8 support URL: https://github.com/apache/mynewt-core/pull/1516#issuecomment-439417568 yes, so I was also worried about whether it would link in unused code/symbols (sdcc seems to have a problem with this), but seems this does not:

[GitHub] ccollins476ad opened a new pull request #241: Fix a few panics

2018-11-16 Thread GitBox
ccollins476ad opened a new pull request #241: Fix a few panics URL: https://github.com/apache/mynewt-newt/pull/241 Malformed or inconsistent YAML files could trigger these two panics. This is an automated message from the

[GitHub] andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234254579 ## File path: apps/bus_test/lis2dh_node/include/lis2dh_node/lis2dh_node.h ## @@ -0,0 +1,46 @@ +/*

[GitHub] zerog2k commented on issue #1516: add bluepill stm32f103c8 support

2018-11-16 Thread GitBox
zerog2k commented on issue #1516: add bluepill stm32f103c8 support URL: https://github.com/apache/mynewt-core/pull/1516#issuecomment-439420535 here's a verbose gist of the clean and build: https://gist.github.com/zerog2k/17695431154b6baba271e26313b50b89 looks like maybe several

[GitHub] mkiiskila commented on a change in pull request #1514: sys/stats/full: Persistent stats

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1514: sys/stats/full: Persistent stats URL: https://github.com/apache/mynewt-core/pull/1514#discussion_r234250779 ## File path: sys/stats/full/src/stats_conf.c ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software

[GitHub] mkiiskila commented on a change in pull request #1514: sys/stats/full: Persistent stats

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1514: sys/stats/full: Persistent stats URL: https://github.com/apache/mynewt-core/pull/1514#discussion_r234251161 ## File path: sys/stats/full/src/stats_conf.c ## @@ -0,0 +1,199 @@ +/* + * Licensed to the Apache Software

[GitHub] rymanluk opened a new pull request #244: nimble/ll: Qualification and performance issues

2018-11-16 Thread GitBox
rymanluk opened a new pull request #244: nimble/ll: Qualification and performance issues URL: https://github.com/apache/mynewt-nimble/pull/244 Yet another set of fixes for the qualification along with fixes for stress testing on extended scanner. One of the major change here is a ref

[GitHub] andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234252810 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software

[GitHub] andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234252936 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software

[GitHub] andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234258876 ## File path: hw/bus/spi/src/spi.c ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software

[GitHub] andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234259265 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software

[GitHub] andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234259357 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234280108 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] utzig commented on issue #1516: add bluepill stm32f103c8 support

2018-11-16 Thread GitBox
utzig commented on issue #1516: add bluepill stm32f103c8 support URL: https://github.com/apache/mynewt-core/pull/1516#issuecomment-439468043 @zero2k Yes, those files are still being compiled because they are seen by `newt` (the build tool) and the are passed to gcc. But if you open of

[GitHub] utzig edited a comment on issue #1516: add bluepill stm32f103c8 support

2018-11-16 Thread GitBox
utzig edited a comment on issue #1516: add bluepill stm32f103c8 support URL: https://github.com/apache/mynewt-core/pull/1516#issuecomment-439468043 @zerog2k Yes, those files are still being compiled because they are seen by `newt` (the build tool) and the are passed to gcc. But if you open

[GitHub] ccollins476ad closed pull request #1514: sys/stats/full: Persistent stats

2018-11-16 Thread GitBox
ccollins476ad closed pull request #1514: sys/stats/full: Persistent stats URL: https://github.com/apache/mynewt-core/pull/1514 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] ccollins476ad commented on issue #1514: sys/stats/full: Persistent stats

2018-11-16 Thread GitBox
ccollins476ad commented on issue #1514: sys/stats/full: Persistent stats URL: https://github.com/apache/mynewt-core/pull/1514#issuecomment-439549554 Thanks, Marko. I have made the requested changes. This is an automated

[mynewt-core] branch master updated: sys/stats/full: Persistent stats

2018-11-16 Thread ccollins
This is an automated email from the ASF dual-hosted git repository. ccollins pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 5294c27 sys/stats/full: Persistent

[GitHub] andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234251853 ## File path: hw/drivers/sensors/bme280/src/bme280.c ## @@ -826,9 +830,21 @@ int

[GitHub] andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
andrzej-kaczmarek commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234259862 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234285408 ## File path: hw/bus/spi/src/spi.c ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation