[GitHub] [mynewt-nimble] h2zero commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-13 Thread GitBox
h2zero commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r407550200 ## File path: nimble/host/src/ble_store_util.c ## @@ -230,16

[GitHub] [mynewt-nimble] h2zero commented on issue #783: Make ble_gap_rx_l2cap_update_req() behave like ble_gap_rx_param_req()

2020-04-13 Thread GitBox
h2zero commented on issue #783: Make ble_gap_rx_l2cap_update_req() behave like ble_gap_rx_param_req() URL: https://github.com/apache/mynewt-nimble/pull/783#issuecomment-612954585 @zacwbond What @rymanluk is saying is that the procedure you are suggesting would go against the bluetooth

[GitHub] [mynewt-nimble] zacwbond commented on issue #783: Make ble_gap_rx_l2cap_update_req() behave like ble_gap_rx_param_req()

2020-04-13 Thread GitBox
zacwbond commented on issue #783: Make ble_gap_rx_l2cap_update_req() behave like ble_gap_rx_param_req() URL: https://github.com/apache/mynewt-nimble/pull/783#issuecomment-612911745 > The reson why it differs between BLE_GAP_EVENT_L2CAP_UPDATE_REQ and BLE_GAP_EVENT_CONN_UPDATE_REQ is

[GitHub] [mynewt-core] apache-mynewt-bot commented on issue #2237: [WIP DNM] Added bsp and mcu packages for dialog_da14695-dk-usb

2020-04-13 Thread GitBox
apache-mynewt-bot commented on issue #2237: [WIP DNM] Added bsp and mcu packages for dialog_da14695-dk-usb URL: https://github.com/apache/mynewt-core/pull/2237#issuecomment-613053754 ## Style check summary ### Our coding style is

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on issue #2237: [WIP DNM] Added bsp and mcu packages for dialog_da14695-dk-usb

2020-04-13 Thread GitBox
apache-mynewt-bot removed a comment on issue #2237: [WIP DNM] Added bsp and mcu packages for dialog_da14695-dk-usb URL: https://github.com/apache/mynewt-core/pull/2237#issuecomment-597785395 ## Style check summary ### Our coding style is