[GitHub] [mynewt-nimble] zacwbond commented on issue #783: Make ble_gap_rx_l2cap_update_req() behave like ble_gap_rx_param_req()

2020-04-16 Thread GitBox
zacwbond commented on issue #783: Make ble_gap_rx_l2cap_update_req() behave like ble_gap_rx_param_req() URL: https://github.com/apache/mynewt-nimble/pull/783#issuecomment-614686578 > @zacwbond Could you please add additional check as @andrzej-kaczmarek suggested? Got it, thanks.

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-16 Thread GitBox
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-614727452 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-16 Thread GitBox
apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-614615008 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-nimble] rymanluk opened a new pull request #799: nimble/host: Minor fixes around the host.

2020-04-16 Thread GitBox
rymanluk opened a new pull request #799: nimble/host: Minor fixes around the host. URL: https://github.com/apache/mynewt-nimble/pull/799 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #799: nimble/host: Minor fixes around the host.

2020-04-16 Thread GitBox
apache-mynewt-bot commented on issue #799: nimble/host: Minor fixes around the host. URL: https://github.com/apache/mynewt-nimble/pull/799#issuecomment-614652316 ## Style check summary ### Our coding style is

[GitHub] [mynewt-nimble] rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-16 Thread GitBox
rymanluk commented on a change in pull request #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#discussion_r409499230 ## File path: nimble/host/src/ble_store_util.c ## @@ -233,13

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-16 Thread GitBox
apache-mynewt-bot removed a comment on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-610780987 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit

2020-04-16 Thread GitBox
apache-mynewt-bot commented on issue #790: nimble/store: Fix nimble store behavior when CCCDs exceed static defined limit URL: https://github.com/apache/mynewt-nimble/pull/790#issuecomment-614615008 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #799: nimble/host: Minor fixes around the host.

2020-04-16 Thread GitBox
apache-mynewt-bot removed a comment on issue #799: nimble/host: Minor fixes around the host. URL: https://github.com/apache/mynewt-nimble/pull/799#issuecomment-614652316 ## Style check summary ### Our coding style is

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #799: nimble/host: Minor fixes around the host.

2020-04-16 Thread GitBox
apache-mynewt-bot commented on issue #799: nimble/host: Minor fixes around the host. URL: https://github.com/apache/mynewt-nimble/pull/799#issuecomment-614869756 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #796: Apps: central added

2020-04-16 Thread GitBox
apache-mynewt-bot removed a comment on issue #796: Apps: central added URL: https://github.com/apache/mynewt-nimble/pull/796#issuecomment-611446715 ## Style check summary No suggestions at this time!

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #796: Apps: central added

2020-04-16 Thread GitBox
apache-mynewt-bot commented on issue #796: Apps: central added URL: https://github.com/apache/mynewt-nimble/pull/796#issuecomment-614506014 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] sjanc commented on a change in pull request #2269: hw/drivers/i2s: Add I2S driver for NRF52 family

2020-04-16 Thread GitBox
sjanc commented on a change in pull request #2269: hw/drivers/i2s: Add I2S driver for NRF52 family URL: https://github.com/apache/mynewt-core/pull/2269#discussion_r409360222 ## File path: hw/drivers/i2s/i2s_nrf52/src/i2s_nrf52.c ## @@ -0,0 +1,235 @@ +/* + * Licensed to

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on issue #796: Apps: central added

2020-04-16 Thread GitBox
apache-mynewt-bot removed a comment on issue #796: Apps: central added URL: https://github.com/apache/mynewt-nimble/pull/796#issuecomment-614506014 ## Style check summary ### Our coding style is

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on issue #796: Apps: central added

2020-04-16 Thread GitBox
apache-mynewt-bot commented on issue #796: Apps: central added URL: https://github.com/apache/mynewt-nimble/pull/796#issuecomment-614542392 ## Style check summary No suggestions at this time! This