[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2295: Make OS_TICKS_PER_SEC configurable for the nRF52 family.

2020-05-26 Thread GitBox
apache-mynewt-bot commented on pull request #2295: URL: https://github.com/apache/mynewt-core/pull/2295#issuecomment-634213726 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] ncasaril commented on pull request #2291: libc/baselibc: Fix definitions for printing 32bit integers

2020-05-26 Thread GitBox
ncasaril commented on pull request #2291: URL: https://github.com/apache/mynewt-core/pull/2291#issuecomment-634355330 > I think this header should be gone or reduced to minimum. > PRI... macros are provided by **inttypes.h** from **gcc**. Perhaps the solution then is to remove the

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request #822: nimble/ll: Fix controller to host flow

2020-05-26 Thread GitBox
andrzej-kaczmarek opened a new pull request #822: URL: https://github.com/apache/mynewt-nimble/pull/822 We should not attempt to allocate credit for data PDU in case of CRC error because such PDU will not be handed over to LL thus we will never get that credit back.

[GitHub] [mynewt-newt] caspermeijn opened a new issue #402: CMake always requires C++ compiler

2020-05-26 Thread GitBox
caspermeijn opened a new issue #402: URL: https://github.com/apache/mynewt-newt/issues/402 I found a minor bug in the CMake generation. When configuring the CMake project, it requires a C++ compiler to be present even if the project doesn't use it. I solved is by doing `sudo dnf install

[GitHub] [mynewt-core] nkaje opened a new pull request #2294: WIP: DA1469x crypto driver

2020-05-26 Thread GitBox
nkaje opened a new pull request #2294: URL: https://github.com/apache/mynewt-core/pull/2294 Let https://github.com/apache/mynewt-core/pull/2175 merge and then merge the top change. This is an automated message from the

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2294: WIP: DA1469x crypto driver

2020-05-26 Thread GitBox
apache-mynewt-bot commented on pull request #2294: URL: https://github.com/apache/mynewt-core/pull/2294#issuecomment-634171978 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] jeremywood commented on issue #1785: Make OS_TICKS_PER_SEC configurable

2020-05-26 Thread GitBox
jeremywood commented on issue #1785: URL: https://github.com/apache/mynewt-core/issues/1785#issuecomment-634213445 I need this too, so I've created a PR that makes this configurable for the nRF52 family. This is an

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #822: nimble/ll: Fix controller to host flow

2020-05-26 Thread GitBox
apache-mynewt-bot commented on pull request #822: URL: https://github.com/apache/mynewt-nimble/pull/822#issuecomment-633615093 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] jeremywood opened a new pull request #2295: Make OS_TICKS_PER_SEC configurable for the nRF52 family.

2020-05-26 Thread GitBox
jeremywood opened a new pull request #2295: URL: https://github.com/apache/mynewt-core/pull/2295 Added a syscfg for the nRF52 family to make it so that OS_TICKS_PER_SEC can be customized on a case by case basis. This is particularly useful for cases where the OS event loop needs to

[GitHub] [mynewt-nimble] ccollins476ad commented on a change in pull request #821: nimble/hs: Fix flow control

2020-05-26 Thread GitBox
ccollins476ad commented on a change in pull request #821: URL: https://github.com/apache/mynewt-nimble/pull/821#discussion_r430039571 ## File path: nimble/include/nimble/ble.h ## @@ -177,8 +177,8 @@ struct ble_mbuf_hdr #define BLE_MBUF_MEMBLOCK_OVERHEAD \

[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #81: cmd/os_mgmt/port/zephyr: zephyr port os enhancement

2020-05-26 Thread GitBox
de-nordic commented on pull request #81: URL: https://github.com/apache/mynewt-mcumgr/pull/81#issuecomment-634061713 Can you point me to where you are reviewing Zephyr west.yml (https://github.com/zephyrproject-rtos/zephyr/pulls) changes for this?

[GitHub] [mynewt-core] apache-mynewt-bot removed a comment on pull request #2286: Add Memfault integration

2020-05-26 Thread GitBox
apache-mynewt-bot removed a comment on pull request #2286: URL: https://github.com/apache/mynewt-core/pull/2286#issuecomment-633534628 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-mcumgr] lgl88911 commented on a change in pull request #81: cmd/os_mgmt/port/zephyr: zephyr port os enhancement

2020-05-26 Thread GitBox
lgl88911 commented on a change in pull request #81: URL: https://github.com/apache/mynewt-mcumgr/pull/81#discussion_r430396654 ## File path: cmd/os_mgmt/port/zephyr/src/zephyr_os_mgmt.c ## @@ -63,12 +64,21 @@ os_mgmt_impl_task_info(int idx, struct os_mgmt_task_info *out_info)

[GitHub] [mynewt-mcumgr] utzig commented on a change in pull request #81: cmd/os_mgmt/port/zephyr: zephyr port os enhancement

2020-05-26 Thread GitBox
utzig commented on a change in pull request #81: URL: https://github.com/apache/mynewt-mcumgr/pull/81#discussion_r430022552 ## File path: cmd/os_mgmt/port/zephyr/src/zephyr_os_mgmt.c ## @@ -63,12 +64,21 @@ os_mgmt_impl_task_info(int idx, struct os_mgmt_task_info *out_info)

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2286: Add Memfault integration

2020-05-26 Thread GitBox
apache-mynewt-bot commented on pull request #2286: URL: https://github.com/apache/mynewt-core/pull/2286#issuecomment-634074495 This is an automated message from the Apache Git Service. To respond to the message, please log on