[GitHub] [mynewt-mcumgr] sjanc commented on pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

sjanc commented on pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#issuecomment-777418259 https://travis-ci.org/github/apache/mynewt-nimble/jobs/758517372 this breaks build... This is an

[GitHub] [mynewt-mcumgr] utzig commented on pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

utzig commented on pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#issuecomment-777423490 > https://travis-ci.org/github/apache/mynewt-nimble/jobs/758517372 > > this breaks build... About time CI is added to this repo...

[GitHub] [mynewt-mcumgr] utzig commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

utzig commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574476913 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #109: mgmt: Uninitialized prev pointer may cause compilation warnings

de-nordic opened a new pull request #109: URL: https://github.com/apache/mynewt-mcumgr/pull/109 Seen while compiling mcumgr with Zephyr: compilation claims possible dereferencing of uninitialized prev pointer. This is not possible situation as the dereferencing of prev depends on

[GitHub] [mynewt-mcumgr] utzig commented on a change in pull request #109: mgmt: Uninitialized prev pointer may cause compilation warnings

utzig commented on a change in pull request #109: URL: https://github.com/apache/mynewt-mcumgr/pull/109#discussion_r574487942 ## File path: mgmt/src/mgmt.c ## @@ -74,7 +74,7 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf) void

[GitHub] [mynewt-mcumgr] de-nordic opened a new pull request #110: Use img_mgmt_find_best_area_id to select upload slot instead of FLASH_AREA_ID

de-nordic opened a new pull request #110: URL: https://github.com/apache/mynewt-mcumgr/pull/110 The mcumgr should relay on single decision point for upload flash area selection; instead the `img_mgmt_find_best_area_id` and FLASH_AREA_ID macros were used for similar purpose through the

[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #829: nimble/host: check read permission in ble_att_svr_build_read_mult_rsp

KKopyscinski commented on pull request #829: URL: https://github.com/apache/mynewt-nimble/pull/829#issuecomment-777464604 @rymanluk Could you review this? This is an automated message from the Apache Git Service. To respond

[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #900: ble_gatt: Add subscribing helper functions

KKopyscinski commented on pull request #900: URL: https://github.com/apache/mynewt-nimble/pull/900#issuecomment-777464546 @rymanluk Could you review this? This is an automated message from the Apache Git Service. To respond

[GitHub] [mynewt-mcumgr] de-nordic closed pull request #109: mgmt: Uninitialized prev pointer may cause compilation warnings

de-nordic closed pull request #109: URL: https://github.com/apache/mynewt-mcumgr/pull/109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #109: mgmt: Uninitialized prev pointer may cause compilation warnings

de-nordic commented on pull request #109: URL: https://github.com/apache/mynewt-mcumgr/pull/109#issuecomment-777474514 @utzig I am leaving that to you as you have alread reported your concerns with the original code. This

[GitHub] [mynewt-mcumgr] utzig opened a new pull request #111: Fix unitialized variable warning

utzig opened a new pull request #111: URL: https://github.com/apache/mynewt-mcumgr/pull/111 Fix usage of prev when curr==group, and add checking for invalid parameter. Fix issues found after #108 This is an automated

[GitHub] [mynewt-core] utzig opened a new pull request #2477: Enable Mbed TLS self-tests which were not running

utzig opened a new pull request #2477: URL: https://github.com/apache/mynewt-core/pull/2477 Enable extra self-tests from Mbed TLS. Added ARIA, CMAC, MD2, MD4 and J-PAKE tests. The test order was sorted for easier reading.

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2477: Enable Mbed TLS self-tests which were not running

apache-mynewt-bot commented on pull request #2477: URL: https://github.com/apache/mynewt-core/pull/2477#issuecomment-777511455 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-core] utzig opened a new pull request #2478: Allow Mbed TLS ECP code to use alt implementations

utzig opened a new pull request #2478: URL: https://github.com/apache/mynewt-core/pull/2478 ECP code can be accelerated when proper short-weierstrass and bignum HW acceleration are present. This adds extra flags to toggle enabling such HW to take over the EC point operations. Must

[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2478: Allow Mbed TLS ECP code to use alt implementations

apache-mynewt-bot commented on pull request #2478: URL: https://github.com/apache/mynewt-core/pull/2478#issuecomment-777529332 ## Style check summary No suggestions at this time! This is an

[GitHub] [mynewt-mcumgr] de-nordic commented on pull request #110: Use img_mgmt_find_best_area_id to select upload slot instead of FLASH_AREA_ID

de-nordic commented on pull request #110: URL: https://github.com/apache/mynewt-mcumgr/pull/110#issuecomment-777544482 @nvlsianpu , @utzig Please check. The Zephyr test commit is here: https://github.com/zephyrproject-rtos/zephyr/pull/32215

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #872: nimble/porting: sync with core

apache-mynewt-bot commented on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777297740 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #872: nimble/porting: sync with core

apache-mynewt-bot removed a comment on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777244550 ## Style check summary No suggestions at this time! This is

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #872: nimble/porting: sync with core

apache-mynewt-bot commented on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777304771 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #872: nimble/porting: sync with core

apache-mynewt-bot removed a comment on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777297740 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-core] KKopyscinski commented on pull request #2457: [RFC] coap: negation in tcp check in coap_receive()

KKopyscinski commented on pull request #2457: URL: https://github.com/apache/mynewt-core/pull/2457#issuecomment-777272213 Closed because the issue was not in the code. We have CoAP ported from ContikiOS, which follows RFC 7959 and received messages came from system following RFC 8323.

[mynewt-newt] branch master updated: docs: Update Windows installation instruction to 1.8

This is an automated email from the ASF dual-hosted git repository. jerzy pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-newt.git The following commit(s) were added to refs/heads/master by this push: new 5da6e2f docs: Update Windows installation

[GitHub] [mynewt-newt] kasjer merged pull request #427: docs: Update Windows installation instruction to 1.8

kasjer merged pull request #427: URL: https://github.com/apache/mynewt-newt/pull/427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #872: nimble/porting: sync with core

apache-mynewt-bot removed a comment on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777304771 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #872: nimble/porting: sync with core

apache-mynewt-bot commented on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777313608 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #872: nimble/porting: sync with core

apache-mynewt-bot commented on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777320198 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #872: nimble/porting: sync with core

apache-mynewt-bot removed a comment on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777313608 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #872: nimble/porting: sync with core

apache-mynewt-bot commented on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777379872 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #872: nimble/porting: sync with core

apache-mynewt-bot removed a comment on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777369628 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #872: nimble/porting: sync with core

apache-mynewt-bot removed a comment on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777320198 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #872: nimble/porting: sync with core

apache-mynewt-bot commented on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777365354 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] KKopyscinski commented on pull request #872: nimble/porting: sync with core

KKopyscinski commented on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777391778 @sjanc Could you review this? I rebased it onto master, copied the files again and checked for confilcts, all travis checks for porting are passing now

[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #872: nimble/porting: sync with core

apache-mynewt-bot commented on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777369628 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-nimble] apache-mynewt-bot removed a comment on pull request #872: nimble/porting: sync with core

apache-mynewt-bot removed a comment on pull request #872: URL: https://github.com/apache/mynewt-nimble/pull/872#issuecomment-777365354 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[mynewt-mcumgr] branch master updated: Fix unitialized variable warning

This is an automated email from the ASF dual-hosted git repository. vipulrahane pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-mcumgr.git The following commit(s) were added to refs/heads/master by this push: new 7be5e26 Fix unitialized variable

[GitHub] [mynewt-mcumgr] vrahane merged pull request #111: Fix unitialized variable warning

vrahane merged pull request #111: URL: https://github.com/apache/mynewt-mcumgr/pull/111 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574680306 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574681140 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574706150 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574676640 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574676640 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574677976 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-mcumgr] vrahane edited a comment on pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane edited a comment on pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#issuecomment-777666374 > https://travis-ci.org/github/apache/mynewt-nimble/jobs/758517372 > > this breaks build... Thank you @sjanc, somehow, I did not see any build issues on

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574702947 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574681140 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-mcumgr] vrahane commented on pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#issuecomment-777666374 > https://travis-ci.org/github/apache/mynewt-nimble/jobs/758517372 > > this breaks build... Thank you @sjanc, I did not see any build issues on the zephyr build

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574677976 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574702947 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-core] utzig merged pull request #2477: Enable Mbed TLS self-tests which were not running

utzig merged pull request #2477: URL: https://github.com/apache/mynewt-core/pull/2477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[mynewt-core] branch master updated: Enable Mbed TLS self-tests which were not running

This is an automated email from the ASF dual-hosted git repository. utzig pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/mynewt-core.git The following commit(s) were added to refs/heads/master by this push: new 461f880 Enable Mbed TLS self-tests which

[GitHub] [mynewt-mcumgr] vrahane commented on a change in pull request #108: mgmt: Add support for un-registering a group along with the same support in img_mgmt

vrahane commented on a change in pull request #108: URL: https://github.com/apache/mynewt-mcumgr/pull/108#discussion_r574676640 ## File path: mgmt/src/mgmt.c ## @@ -71,6 +71,31 @@ mgmt_streamer_free_buf(struct mgmt_streamer *streamer, void *buf)

[GitHub] [mynewt-core] utzig commented on pull request #2461: stm32 spi bus driver

utzig commented on pull request #2461: URL: https://github.com/apache/mynewt-core/pull/2461#issuecomment-43696 @kasjer Please rebase. This is an automated message from the Apache Git Service. To respond to the message,