[GitHub] [mynewt-nimble] sjanc edited a comment on issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`

2021-06-02 Thread GitBox
sjanc edited a comment on issue #983: URL: https://github.com/apache/mynewt-nimble/issues/983#issuecomment-852908520 yes, this is currently named like that for historical reasons :) but I'm totally fine with adding wrappers with fixed names and marking old ones as deprecated. Would you

[GitHub] [mynewt-nimble] sjanc commented on issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`

2021-06-02 Thread GitBox
sjanc commented on issue #983: URL: https://github.com/apache/mynewt-nimble/issues/983#issuecomment-852908520 yes, this is currently for historical reasons :) but I'm totally fine with adding wrappers with fixed names and marking old ones as deprecated. Would you like to send such PR?

[GitHub] [mynewt-nimble] tanupattrin opened a new issue #984: New ble

2021-06-02 Thread GitBox
tanupattrin opened a new issue #984: URL: https://github.com/apache/mynewt-nimble/issues/984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [mynewt-nimble] tanupattrin closed issue #984: New ble

2021-06-02 Thread GitBox
tanupattrin closed issue #984: URL: https://github.com/apache/mynewt-nimble/issues/984 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [mynewt-nimble] Wth-Esp commented on issue #983: Suggest change the name of function `ble_gattc_notify` and `ble_gattc_notify_custom` into `ble_gatts_notify`and `ble_gatts_notify_custom`

2021-06-02 Thread GitBox
Wth-Esp commented on issue #983: URL: https://github.com/apache/mynewt-nimble/issues/983#issuecomment-853069174 @sjanc Yes, I'm willing to do this. Please wait for my updates, maybe I will change other mistakes by the way. When the PR is ready, I will close this issue, thanks for your