[GitHub] [mynewt-nimble] utzig commented on pull request #1249: porting: fix npl to allow NimBLE version bump in RIOT

utzig commented on PR #1249: URL: https://github.com/apache/mynewt-nimble/pull/1249#issuecomment-1122860390 ## Style check summary ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)

[GitHub] [mynewt-mcumgr] vrahane commented on a diff in pull request #159: zephyr: update include paths to use

vrahane commented on code in PR #159: URL: https://github.com/apache/mynewt-mcumgr/pull/159#discussion_r869663940 ## samples/omp_svr/mynewt/src/main.c: ## @@ -21,9 +21,9 @@ #include #include #include -#include +#include #include -#include +#include Review Comment:

[GitHub] [mynewt-mcumgr] vrahane commented on a diff in pull request #159: zephyr: update include paths to use

vrahane commented on code in PR #159: URL: https://github.com/apache/mynewt-mcumgr/pull/159#discussion_r869663683 ## samples/omp_svr/mynewt/src/main.c: ## @@ -21,9 +21,9 @@ #include #include #include -#include +#include Review Comment: Please do not change this.

[GitHub] [mynewt-mcumgr] gmarull opened a new pull request, #159: zephyr: update include paths to use

gmarull opened a new pull request, #159: URL: https://github.com/apache/mynewt-mcumgr/pull/159 Zephyr has prefixed all of its includes with . While the old mode can still be used (CONFIG_LEGACY_INCLUDE_PATH) and is still enabled by default, it's better to be prepared for its removal in

[GitHub] [mynewt-nimble] kasjer commented on pull request #1244: nimble/ll: Add more HCI commands for fake dual-mode

kasjer commented on PR #1244: URL: https://github.com/apache/mynewt-nimble/pull/1244#issuecomment-1122174759 Tested on Windows and Linux without problems -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [mynewt-nimble] kasjer opened a new pull request, #1256: transport/usb: Enable BTH in TinyUSB stack

kasjer opened a new pull request, #1256: URL: https://github.com/apache/mynewt-nimble/pull/1256 Setting USBD_BTH to 1 is required to enable code in TinyUSB stack. Due to newt limitation this value could not only be set target or application. Now USBD_BTH is defined by not set and

[GitHub] [mynewt-core] utzig commented on pull request #2834: tinyusb: USB function enable rework

utzig commented on PR #2834: URL: https://github.com/apache/mynewt-core/pull/2834#issuecomment-1122907333 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [mynewt-nimble] utzig commented on pull request #1256: transport/usb: Enable BTH in TinyUSB stack

utzig commented on PR #1256: URL: https://github.com/apache/mynewt-nimble/pull/1256#issuecomment-1123016008 ## Style check summary No suggestions at this time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [mynewt-nimble] haukepetersen commented on pull request #1249: porting: fix npl to allow NimBLE version bump in RIOT

haukepetersen commented on PR #1249: URL: https://github.com/apache/mynewt-nimble/pull/1249#issuecomment-1121978858 - added one more fix: include "os_cputime.h" for the nrf51 PHY driver - rebased -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [mynewt-core] kasjer opened a new pull request, #2834: tinyusb: USB function enable rework

kasjer opened a new pull request, #2834: URL: https://github.com/apache/mynewt-core/pull/2834 USB function in TinyUSB stack is enabled by one of the following definitions: CFG_TUD_CDC, CFG_TUD_HID, CFG_TUD_MSC, CFG_TUD_MIDI, CFG_TUD_MSC, CFG_TUD_VENDOR, CFG_TUD_USBTMC, CFG_TUD_DFU_RT,