[GitHub] [mynewt-core] kasjer commented on a change in pull request #2093: console history persistence
kasjer commented on a change in pull request #2093: console history persistence URL: https://github.com/apache/mynewt-core/pull/2093#discussion_r35310 ## File path: sys/console/full/syscfg.yml ## @@ -43,15 +43,31 @@ syscfg.defs: value: 256 CONSOLE_HISTORY_SIZE: description: > -Number of lines to be stored in console history. -Set to "0" to disable console history. +This is no longer used. +Equivalent settings: +CONSOLE_HISTORY: ram +CONSOLE_HISTORY_RAM_HISTORY_SIZE:<- previous value of CONSOLE_HISTORY_SIZE value: 0 -CONSOLE_MAX_PROMPT_LEN: +deprecated: 1 +CONSOLE_HISTORY: +description: > +Select how console should handle command history. +value: none +choices: +- none # no history support +- ram # history kept in ram for current session only +- log # history kept in log +CONSOLE_HISTORY_AUTO_SEARCH: +description: > +When set to 1 history is automatically searched for lines starting with already typed +text. +value: 0 +CONSOLE_PROMPT_MAX_LEN: description: 'Maximum number of characters for prompt' value: 16 -CONSOLE_STICKY_PROMPT: +CONSOLE_PROMPT_PERSIST: Review comment: switched to CONSOLE_PROMPT_STICKY This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] kasjer commented on a change in pull request #2093: console history persistence
kasjer commented on a change in pull request #2093: console history persistence URL: https://github.com/apache/mynewt-core/pull/2093#discussion_r353102379 ## File path: sys/console/full/syscfg.yml ## @@ -43,15 +43,31 @@ syscfg.defs: value: 256 CONSOLE_HISTORY_SIZE: description: > -Number of lines to be stored in console history. -Set to "0" to disable console history. +This is no longer used. +Equivalent settings: +CONSOLE_HISTORY: ram +CONSOLE_HISTORY_RAM_HISTORY_SIZE:<- previous value of CONSOLE_HISTORY_SIZE value: 0 -CONSOLE_MAX_PROMPT_LEN: +deprecated: 1 Review comment: moved to end and changed to defunct This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [mynewt-core] kasjer commented on a change in pull request #2093: console history persistence
kasjer commented on a change in pull request #2093: console history persistence URL: https://github.com/apache/mynewt-core/pull/2093#discussion_r353102057 ## File path: sys/console/full/history_log/src/history_log.c ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#include +#include +#include +#if MYNEWT_VAL(LOG_FCB) +#include +#endif +#if MYNEWT_VAL(LOG_FCB2) +#include +#endif +#include +#include + +#define HISTORY_CACHE_SIZE MYNEWT_VAL(CONSOLE_HISTORY_LOG_CACHE_SIZE) + +#define VARIANT 2 Review comment: indeed, removed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
