[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2902: hw/ipc_nrf5340: Some updates

[GitBox]

sjanc commented on code in PR #2902:
URL: https://github.com/apache/mynewt-core/pull/2902#discussion_r994226671


##
hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c:
##
@@ -470,6 +470,25 @@ ipc_nrf5340_available_buf(int channel, void **dptr)
 return 0;
 }
 
+uint16_t
+ipc_nrf5340_data_available_get(int channel)

Review Comment:
   hmm fair enough,  but it could use ipc_nrf5340_shm_get_data_length() 
internally anyway ;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2902: hw/ipc_nrf5340: Some updates

[GitBox]

sjanc commented on code in PR #2902:
URL: https://github.com/apache/mynewt-core/pull/2902#discussion_r994219259


##
hw/drivers/ipc_nrf5340/include/ipc_nrf5340/ipc_nrf5340.h:
##
@@ -131,6 +131,32 @@ uint16_t ipc_nrf5340_available(int channel);
  */
 uint16_t ipc_nrf5340_available_buf(int channel, void **dptr);
 
+/**
+ * Returns number of free space available in IPC ring buffer.

Review Comment:
   copy-paste?  same as ipc_nrf5340_data_available_get() and doesn't match 
implementation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [mynewt-core] sjanc commented on a diff in pull request #2902: hw/ipc_nrf5340: Some updates

[GitBox]

sjanc commented on code in PR #2902:
URL: https://github.com/apache/mynewt-core/pull/2902#discussion_r994213234


##
hw/drivers/ipc_nrf5340/src/ipc_nrf5340.c:
##
@@ -470,6 +470,25 @@ ipc_nrf5340_available_buf(int channel, void **dptr)
 return 0;
 }
 
+uint16_t
+ipc_nrf5340_data_available_get(int channel)

Review Comment:
   there is already ipc_nrf5340_available() for this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org