[GitHub] andrzej-kaczmarek closed pull request #33: nimble/phy: Allow to selectively enable workaround for nRF52840

[GitBox]

andrzej-kaczmarek closed pull request #33: nimble/phy: Allow to selectively 
enable workaround for nRF52840
URL: https://github.com/apache/mynewt-nimble/pull/33
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/nimble/drivers/nrf52/src/ble_phy.c 
b/nimble/drivers/nrf52/src/ble_phy.c
index ac689c93..39a98128 100644
--- a/nimble/drivers/nrf52/src/ble_phy.c
+++ b/nimble/drivers/nrf52/src/ble_phy.c
@@ -280,20 +280,28 @@ ble_phy_apply_nrf52840_errata(uint8_t new_phy_mode)
     }
 
     if (new_coded) {
+#if MYNEWT_VAL(BLE_PHY_NRF52840_ERRATA_164)
         /* [164] */
         *(volatile uint32_t *)0x4000173C |= 0x80000000;
         *(volatile uint32_t *)0x4000173C =
                         ((*(volatile uint32_t *)0x4000173C & 0xFFFFFF00) | 
0x5C);
+#endif
+#if MYNEWT_VAL(BLE_PHY_NRF52840_ERRATA_191)
         /* [191] */
         *(volatile uint32_t *) 0x40001740 =
                         ((*((volatile uint32_t *) 0x40001740)) & 0x7FFF00FF) |
                         0x80000000 | (((uint32_t)(196)) << 8);
+#endif
     } else {
+#if MYNEWT_VAL(BLE_PHY_NRF52840_ERRATA_164)
         /* [164] */
         *(volatile uint32_t *)0x4000173C &= ~0x80000000;
+#endif
+#if MYNEWT_VAL(BLE_PHY_NRF52840_ERRATA_191)
         /* [191] */
         *(volatile uint32_t *) 0x40001740 =
                         ((*((volatile uint32_t *) 0x40001740)) & 0x7FFFFFFF);
+#endif
     }
 }
 #endif
diff --git a/nimble/drivers/nrf52/syscfg.yml b/nimble/drivers/nrf52/syscfg.yml
index b4088aa1..3feb68bb 100644
--- a/nimble/drivers/nrf52/syscfg.yml
+++ b/nimble/drivers/nrf52/syscfg.yml
@@ -52,3 +52,21 @@ syscfg.defs:
             state when wfr timer expires.
             This can be used to check if wfr is calculated properly.
         value: -1
+
+    BLE_PHY_NRF52840_ERRATA_164:
+        description: >
+            Enable workaround for anomaly 164 found in nRF52840.
+            "[164] RADIO: Low selectivity in long range mode"
+            This shall be only enabled for:
+            - nRF52840 Engineering A
+        value: 0
+
+    BLE_PHY_NRF52840_ERRATA_191:
+        description: >
+            Enable workaround for anomaly 191 found in nRF52840.
+            "[191] RADIO: High packet error rate in BLE Long Range mode"
+            This shall be only enabled for:
+            - nRF52840 Engineering B
+            - nRF52840 Engineering C
+            - nRF52840 Rev 1 (final silicon)
+        value: 1


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services