[GitHub] ccollins476ad commented on a change in pull request #822: Adding int/float easing library

[GitBox]

ccollins476ad commented on a change in pull request #822: Adding int/float 
easing library
URL: https://github.com/apache/mynewt-core/pull/822#discussion_r170065278
 
 

 ##
 File path: util/easing/pkg.yml
 ##
 @@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: util/easing
+pkg.description: Library containing easing functions
+pkg.author: "Apache Mynewt "
+pkg.homepage: "http://mynewt.apache.org/;
+pkg.keywords:
+- easing
+
+pkg.cflags:
+- "-lm"
 
 Review comment:
   You should add `-lm` to `pkg.lflags` (not `pkg.cflags`).  However, this will 
only work with a fairly recent version of newt (you need this PR, merged Feb. 
13: https://github.com/apache/mynewt-newt/pull/133).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] ccollins476ad commented on a change in pull request #822: Adding int/float easing library

[GitBox]

ccollins476ad commented on a change in pull request #822: Adding int/float 
easing library
URL: https://github.com/apache/mynewt-core/pull/822#discussion_r170065278
 
 

 ##
 File path: util/easing/pkg.yml
 ##
 @@ -0,0 +1,28 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#  http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+pkg.name: util/easing
+pkg.description: Library containing easing functions
+pkg.author: "Apache Mynewt "
+pkg.homepage: "http://mynewt.apache.org/;
+pkg.keywords:
+- easing
+
+pkg.cflags:
+- "-lm"
 
 Review comment:
   You should add `-lm` to `pkg.lflags` (not `pkg.cflags`).  However, this will 
only work with a fairly recent version of newt (you need this PR, merged Feb. 
13: https://github.com/apache/mynewt-newt/pull/133#event-1472935366).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services