[GitHub] ccollins476ad commented on issue #1173: Awkward log API requires padded buffer

2018-06-13 Thread GitBox
ccollins476ad commented on issue #1173: Awkward log API requires padded buffer URL: https://github.com/apache/mynewt-core/issues/1173#issuecomment-397086367 Andrzej, that sounds good, though it might be a bit tricky. Perhaps it can be addressed in a later PR :).

[GitHub] ccollins476ad commented on issue #1173: Awkward log API requires padded buffer

2018-06-13 Thread GitBox
ccollins476ad commented on issue #1173: Awkward log API requires padded buffer URL: https://github.com/apache/mynewt-core/issues/1173#issuecomment-397047321 I thought of an obvious solution to this problem: 1. The `log_append` functions define a small buffer on the stack, with size

[GitHub] ccollins476ad commented on issue #1173: Awkward log API requires padded buffer

2018-06-12 Thread GitBox
ccollins476ad commented on issue #1173: Awkward log API requires padded buffer URL: https://github.com/apache/mynewt-core/issues/1173#issuecomment-396791926 Looking into this a bit more, I discovered a few things: 1. The `log_append_mbuf` and `log_append_mbuf_typed` functions assume

[GitHub] ccollins476ad commented on issue #1173: Awkward log API requires padded buffer

2018-06-12 Thread GitBox
ccollins476ad commented on issue #1173: Awkward log API requires padded buffer URL: https://github.com/apache/mynewt-core/issues/1173#issuecomment-396791926 Looking into this a bit more, I discovered a few things: 1. The `log_append_mbuf` and `log_append_mbuf_typed` functions assume

[GitHub] ccollins476ad commented on issue #1173: Awkward log API requires padded buffer

2018-06-12 Thread GitBox
ccollins476ad commented on issue #1173: Awkward log API requires padded buffer URL: https://github.com/apache/mynewt-core/issues/1173#issuecomment-396735662 Thanks for the correction, Marko. That makes sense. I propose the following changes: 1. Modify the log entry header such

[GitHub] ccollins476ad commented on issue #1173: Awkward log API requires padded buffer

2018-06-12 Thread GitBox
ccollins476ad commented on issue #1173: Awkward log API requires padded buffer URL: https://github.com/apache/mynewt-core/issues/1173#issuecomment-396735662 Thanks for the correction, Marko. That makes sense. I propose the following changes: 1. Modify the log entry header such

[GitHub] ccollins476ad commented on issue #1173: Awkward log API requires padded buffer

2018-06-12 Thread GitBox
ccollins476ad commented on issue #1173: Awkward log API requires padded buffer URL: https://github.com/apache/mynewt-core/issues/1173#issuecomment-396735662 Thanks for the correction, Marko. That makes sense. I propose the following changes: 1. Modify the log entry header such

[GitHub] ccollins476ad commented on issue #1173: Awkward log API requires padded buffer

2018-06-12 Thread GitBox
ccollins476ad commented on issue #1173: Awkward log API requires padded buffer URL: https://github.com/apache/mynewt-core/issues/1173#issuecomment-396735662 Thanks for the correction, Marko. That makes sense. I propose the following changes: 1. Modify the log entry header such