[GitHub] jacobrosenthal commented on issue #757: HW driver: drv2605l

2018-02-12 Thread GitBox
jacobrosenthal commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-365048037 Since this is approved I figured I can do it myself? Also of note, WIP documentation is being worked on here https://github.com/apache/mynewt-documentati

[GitHub] jacobrosenthal commented on issue #757: HW driver: drv2605l

2018-02-08 Thread GitBox
jacobrosenthal commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-364176451 @mkiiskila check again. I noticed there are other _writelen with different style. Preferences on how to correct these others https://github.com/apache/m

[GitHub] jacobrosenthal commented on issue #757: HW driver: drv2605l

2018-02-07 Thread GitBox
jacobrosenthal commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-363963832 Think Im good to go. I just need @mkiiskila to approve the fixes for his two comments --

[GitHub] jacobrosenthal commented on issue #757: HW driver: drv2605l

2018-02-07 Thread GitBox
jacobrosenthal commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-363944821 Seems like tutorials in the docs repo are the common way of doing this atm. Ill get something baed on these instructions over there next On Wed, Fe

[GitHub] jacobrosenthal commented on issue #757: HW driver: drv2605l

2018-02-05 Thread GitBox
jacobrosenthal commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-363155939 ping @microbuilder Been a week since I fiddled with it, Im ready to call it ready for review --

[GitHub] jacobrosenthal commented on issue #757: HW driver: drv2605l

2018-02-05 Thread GitBox
jacobrosenthal commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-363155939 ping @microbuilder Been a weeks since I fiddled with it, Im ready to call it ready for review -

[GitHub] jacobrosenthal commented on issue #757: HW driver: drv2605l

2018-01-28 Thread GitBox
jacobrosenthal commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-361089441 Merged that branch here. Also just put everything in sensor creator so theres an obvious example, we can just rebase that out if people dont like it For

[GitHub] jacobrosenthal commented on issue #757: HW driver: drv2605l

2018-01-28 Thread GitBox
jacobrosenthal commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-361089441 Merged that branch here. Also just put everything in sensor creator so theres an obvious example, we can just rebase that out if people dont like it For

[GitHub] jacobrosenthal commented on issue #757: HW driver: drv2605l

2018-01-28 Thread GitBox
jacobrosenthal commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-361089441 Merged that branch here. Also just put everything in sensor creator so theres an obvious example, we can just rebase that out if people dont like it For

[GitHub] jacobrosenthal commented on issue #757: HW driver: drv2605l

2018-01-28 Thread GitBox
jacobrosenthal commented on issue #757: HW driver: drv2605l URL: https://github.com/apache/mynewt-core/pull/757#issuecomment-361089441 Merged that branch here. Also just put everything in sensor creator so theres an obvious example, we can just rebase that out if people dont like it For