[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes
joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-381252318 Thank for @ccollins476ad for the very helpful explanation. If finally get it! Now, after I did a force to my fork the PR was automatically closed. Is the expectation that I create a new PR base on the new commits in my fork? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes
joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-381202294 Hi @sterlinghughes @rymanluk, quick question. I made the remaining changes, tested the code on my bmd300eval, and successfully did git pull --rebase origin master (from the apache mynewt-core repo). All works well. However, when I try to push to my fork it says it has diverged to much and I must to a git pull from that remote (fork/master in my repo). I tried to a git pull --rebase fork master to align, but I am getting a lot of unexpected conflicts. I looked at some documentation about syncing forks, but something is not working as smoothly as expected. In short, what it is the best way to push my changes to pull request after I have successfully rebased my changes locally? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes
joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-381202294 Hi @sterlinghughes @rymanluk, quick question. I made the remaining changes, tested the code on my bmd300eval, and successfully did git pull --rebase origin master (from the apache mynewt-core repo). All works well. However, when I try to push to my fork it says it has diverged to much and I must to a git pull from that remote (fork/master in my repo). I tried to a git pull --rebase fork master to align, but I am getting a lot of unexpected conflicts. In short, what it is the best way to push my changes to pull request after I have successfully rebased my changes locally? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes
joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-378793911 Sorry, I know the delays here are lame. I am traveling right now, and have it top of mind to test everything one last time before the final commit when I return and have my hardware setup. I return on Monday. Many apologies, and thank you for the follow ups. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes
joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-375346186 Okay I added my comments. Will do the rebase after my comments are reviewed. Will keep slack open and am reachable there for more detailed conversations. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes
joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-370888951 Hi @sterlinghughes many apologies for the delay in my comments. Yes, I will try and respond by the end of the week or early next. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes
joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-353613486 @rymanluk Hope all is well. Any additional thoughts on this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes
joshgrob commented on issue #699: Sensors/BMA2XX - New PR based on PR #697 changes URL: https://github.com/apache/mynewt-core/pull/699#issuecomment-352527275 rebase should be complete. Lemme know if something looks off, and thanks for the help in troubleshooting @rymanluk This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
