[GitHub] kasjer commented on issue #1015: nrf52840 support for qspi flash
kasjer commented on issue #1015: nrf52840 support for qspi flash URL: https://github.com/apache/mynewt-core/pull/1015#issuecomment-381259746 @wes3 I agree, I will move definitions to MCU and I will add preprocessor checks to detect unchanged values as you suggested, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] kasjer commented on issue #1015: nrf52840 support for qspi flash
kasjer commented on issue #1015: nrf52840 support for qspi flash URL: https://github.com/apache/mynewt-core/pull/1015#issuecomment-381255576 @wes3 I though about putting all definition in MCU. I moved some of them to the BSP because there are not sensible default values for pins or flash size. If you think that it is more mynewt way to put them in MCU and then override them in BSP I have no objections. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
