[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234285408 ## File path: hw/bus/spi/src/spi.c ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234280108 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234144177 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234146746 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234147553 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234147288 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234148399 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234151068 ## File path: hw/bus/spi/src/spi.c ## @@ -0,0 +1,225 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234143032 ## File path: hw/drivers/sensors/bme280/src/bme280.c ## @@ -826,9 +830,21 @@ int bme280_readlen(struct

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-16 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r234144300 ## File path: hw/bus/src/bus.c ## @@ -0,0 +1,314 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver

2018-11-13 Thread GitBox
mkiiskila commented on a change in pull request #1507: [RFC] Add generic serial bus driver URL: https://github.com/apache/mynewt-core/pull/1507#discussion_r233082654 ## File path: hw/bus/include/bus/bus.h ## @@ -0,0 +1,212 @@ +/* + * Licensed to the Apache Software